Discuss clang-format options.#81
Closed
ahmedcharles wants to merge 1 commit intoMudlet:developmentfrom
ahmedcharles:options
Closed
Discuss clang-format options.#81ahmedcharles wants to merge 1 commit intoMudlet:developmentfrom ahmedcharles:options
ahmedcharles wants to merge 1 commit intoMudlet:developmentfrom
ahmedcharles:options
Conversation
This isn't meant to be merged, but rather, be a discussion about which options people want to use. I've added comments next to each formatting option that clang-format supports and that we specify. Many of them are fairly obvious choices and some of the settings I'm ignoring for now, either for future discussion or because they are for fine tuning later and not important at the moment. For things I want to call out as potentially contentious, I'll have the comments start with **'s.
Contributor
Author
|
Note, the link to the options is: http://clang.llvm.org/docs/ClangFormatStyleOptions.html |
Member
There was a problem hiding this comment.
This may break QMaps, such as QMap< QString, QMap< QString, QString> >
Contributor
Author
There was a problem hiding this comment.
clang-format adds a space between the >'s at the end, when needed in C++03, but it removes them in C++11, since they aren't required.
Member
There was a problem hiding this comment.
SpacesInAngles: false sounds fine with me.
Member
There was a problem hiding this comment.
Awesome, the > > always bugged me.
Contributor
Author
|
These changes went in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't meant to be merged, but rather, be a discussion about which
options people want to use. I've added comments next to each formatting
option that clang-format supports and that we specify. Many of them are
fairly obvious choices and some of the settings I'm ignoring for now,
either for future discussion or because they are for fine tuning later and
not important at the moment.
For things I want to call out as potentially contentious, I'll have the
comments start with **'s.