fix createConsole wrongly rejecting all window names#7809
Merged
ZookaOnGit merged 12 commits intoMudlet:developmentfrom Apr 23, 2025
Merged
fix createConsole wrongly rejecting all window names#7809ZookaOnGit merged 12 commits intoMudlet:developmentfrom
ZookaOnGit merged 12 commits intoMudlet:developmentfrom
Conversation
…into development
…into development
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
|
vadi2
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Fix createConsole rejecting all window names.
Motivation for adding to Mudlet
I was testing a PR and found that I couldn't create a console.
Other info (issues closed, discussion etc)
#7634 added a type check on wrong variable, instead of fixing it, I'll just rename the uses of the local variable to be consistent with others