Fix packages not behaving as same as modules#7729
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
@vadi2 Also while debugging this i found out some logs are not shown in the main console, For example if you run mudlet with |
Found the issue, It's because of diff --git a/src/mudlet-lua/lua/Other.lua b/src/mudlet-lua/lua/Other.lua
index 9d7ec2c9..9b28b4b4 100644
--- a/src/mudlet-lua/lua/Other.lua
+++ b/src/mudlet-lua/lua/Other.lua
@@ -784,7 +784,7 @@ function condenseMapLoad()
for i = 1, 30 do
moveCursor(0, getLineCount() - i)
local line = getCurrentLine()
- if line:find("ALERT") or line:find("WARN") or line:find("ERROR") then
+ if line:find("ALERT") or line:find("WARN") or line:find("ERROR") or line:find("LUA") then
return nil, "an alert, warning, or error that the user must see is present"
elseif startswith(line, "[ INFO ] - Reading map") then
linestodelete = iThis patch would fix it, Do i include this in this pr or create another pr for it? |
|
@vadi2 kindly reminder to review :) |
|
I don't have a lot of bandwidth to review this... @demonnic or @ZookaOnGit ? |
|
Hello, Any update on this? |
|
I will take a look. Fixed initial post to reflect template, please follow in the future. |
|
Installed as package, get ladybug every time (which is actually what we are after) after profile restart, same behavior exhibited as module install. From a user perspective this seems fixed. |
Brief overview of PR changes/additions
Fix issue compiling children scripts more than enough and also out of order.
Motivation for adding to Mudlet
Show same error message when using as a module or package.
Other info (issues closed, discussion etc)
fixes #6460
/claim #6460