improve: script editor search results can be resized#7626
Merged
vadi2 merged 8 commits intoMudlet:developmentfrom Jan 5, 2025
Merged
improve: script editor search results can be resized#7626vadi2 merged 8 commits intoMudlet:developmentfrom
vadi2 merged 8 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
reviewed
Jan 1, 2025
Member
vadi2
left a comment
There was a problem hiding this comment.
I agree, the show/hide button can probably go now.
Does the splitter remember where it was across Mudlet restarts?
Contributor
Author
no, it will always start at just showing the search term input bar would you like that feature? |
Member
|
Would be nice, what do you think? The default size on Appimage is a bit small btw: |
Contributor
Author
|
added suggestions |
vadi2
approved these changes
Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Allow the script editor search results to be resized. It can be resized all the way to hidden.
Motivation for adding to Mudlet
Improves user experience.
Other info (issues closed, discussion etc)
Wondering if the toggle show/hide results button is really necessary now?
Peek.2025-01-01.16-59.webm
closes #2905
/claim #2905