Fix: show room symbols at smaller sizes#7593
Conversation
#### Brief overview of PR changes/additions Allow the font used to draw room symbols to be half the previous minimum so that they show at even smaller sizes and thus are shown when the map is zoomed out more. #### Motivation for adding to Mudlet Someone (@Kebap) was unhappy at the size at which symbols were not being shown. #### Other info (issues closed, discussion etc) If accepted this will close Mudlet#5320 and allow me to /claim Mudlet#5320. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
For me, this works fine. Compare this to the behavior shown in the original issue:
Not only do the symbols hide later, they also hide at the same time, and don't arbitrarily reappear neither. This change will likely influence other folks who write stuff on their rooms, so needs more testing and review in PTB. |
That means the other limit is being reached - the one for the overall size of rooms (8 pixels IIRC) rather than the font limit - the latter will still come into play for a symbol that is more than one or two graphemes I expect... |
|
I thought there was more to the issue at hand. Nice job solving this simply 👍 |
Brief overview of PR changes/additions
Allow the font used to draw room symbols to be half the previous minimum so that they show at even smaller sizes and thus are shown when the map is zoomed out more.
Motivation for adding to Mudlet
Someone (@Kebap) was unhappy at the size at which symbols were not being shown.
Other info (issues closed, discussion etc)
If accepted this will close #5320 and allow me to /claim #5320.