Skip to content

improve "move to area" to preselect current shown area in combobox#7555

Merged
vadi2 merged 1 commit intoMudlet:developmentfrom
ZookaOnGit:move-to-area-popup-5221
Dec 14, 2024
Merged

improve "move to area" to preselect current shown area in combobox#7555
vadi2 merged 1 commit intoMudlet:developmentfrom
ZookaOnGit:move-to-area-popup-5221

Conversation

@ZookaOnGit
Copy link
Copy Markdown
Contributor

Brief overview of PR changes/additions

On the mapper, when right-click -> "move to area" is chosen it defaults to the first entry of areas. This improvement now selects the current area shown in the mapper.

Motivation for adding to Mudlet

Better user experience.
/claim #5221

Other info (issues closed, discussion etc)

closes #5221

@ZookaOnGit ZookaOnGit requested a review from a team as a code owner December 13, 2024 11:03
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Dec 13, 2024

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

Copy link
Copy Markdown
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended

@SlySven
Copy link
Copy Markdown
Member

SlySven commented Dec 13, 2024

Not to be a wet sponge but if you are moving rooms to another area the current area is going to be the one area that you are not going to select.

😕

On the other hand I suppose that perhaps from a UI perspective it does reinforce that "yes here they are now in this area - so where are you gonna change it to..."

@ZookaOnGit
Copy link
Copy Markdown
Contributor Author

Actually, you can select rooms and choose a new area then decide to right-click and it will use the current area you have decided/shown.

@vadi2 vadi2 merged commit 9fa6601 into Mudlet:development Dec 14, 2024
@ZookaOnGit ZookaOnGit deleted the move-to-area-popup-5221 branch December 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select current area in map "Area" popup

3 participants