Conversation
This reverts commit 8d83f78.
|
You mean it reverts PR #7039. Looking at the contributor's GitHub activity, since they joined GH in Oct '23 they have not done anything there since Feb '24: Though they do have a As for the defects reported - can you list some references to those as I did say in my review to the original PR that there was something I was considering doing to improve the Far-Easter locale behaviour - I am not sure if that was the only problem or if there were others... |
|
#7316 explains what issues are folks having, have a look |
|
Please refresh links for this one, I have some mini consoles to check to see if this resolves the issue there. Thanks! |
|
Sure thing, they should be there soon. |
|
The links did not show up - I see on my PR that section with the links is missing too. Thank you for putting up with Infrastructure issues. |
|
/refresh links |
|
/create links |
|
Here are some samples of oddity with Consoles that we hope will go away: |
|
Can anything be done to expose these links? :) |
|
It seems the bot is dead-dead :(. In the meantime the artifacts will be available on https://github.com/Mudlet/Mudlet/actions/runs/11064836859 (once built) |
|
/create links |
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
@mpconley there you go! The bot is back. |
|
The usual tricks to open up one of these on a Mac are not working. Is there anything in the builds that could help out a little so we could "Open Anyway" or are we in trouble? I do have 1 more Mac update to make from this week - I will see if that helps. 
|
|
Unfortunately not for Mac. I will see if I could fork this and test somehow to get it in. |
|
I think the new sequoia update blocks running unsigned apps entirely unfortunately. We'd have to get build singing back in, though I'm not sure if it's safe to enable that for PRs from forked repos. Does anyone know if secrets are safe to be shared with PRs from forked repos? |
|
I built this from the local branch and it works as expected. With the StickMUD UI in most consoles I have a 
|
|
@SlySven how about a merge on this one? It is very much needed. |
SlySven
left a comment
There was a problem hiding this comment.
Given that we are reverting to prior code I don't see any reason why it shouldn't go back - but we'd better reopen the issues that the original PR was going to close.
TBH I haven't looked into how the current code "doesn't work" and what we are changing back to. I guess that at some point the code we are removing here will be fixed up and go back in when it does what we hoped it would do...
|
It would be great to have your eyes on this one @SlySven |
Brief overview of PR changes/additions
This reverts commit 8d83f78 / PR #7039.
Motivation for adding to Mudlet
Fixes #7316
Other info (issues closed, discussion etc)
This is a high-level issue that has been affecting many players for many months now, and unfortunately it has no traction in getting fixed. It is also holding up a release. Lets revert it so we can do a release with all of the other fixes that have been done.
The bounty for the original issue was already paid out and unfortunately the author is unresponsive in providing a fix, so we'll just deduct the incorrectly paid out bounty amount in a future bounty.