Fix: 64bit Mudlet on Windows does not play sounds#7391
Fix: 64bit Mudlet on Windows does not play sounds#7391vadi2 merged 11 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
I checked that winqt6deploy copies the DLL file to the folder, but I will modify the script to be sure. |
|
Sorry, I've been playing with Copying a file across manually only becomes an issue when building a debug version (and the CI script versions are not currently set up to do that) as the tool does not copy the |
|
Perhaps I wasn't clear - you can revert 5499794 as "we ain't gonna need it"... 😊 |
I was on the wrong track and requested something that wasn't/isn't needed.
SlySven
left a comment
There was a problem hiding this comment.
This works for me. Fair enough I suggested the code but @joaquin30 deserves the reward for tracking down the needed environmental variable...
... it is theoretically possible that the scope of this setting might need to be expanded to also do something for other OSes when we start working on Qt6 for those as well.
In practice the supposed "default" value of ffmpeg as a setting for QT_MEDIA_BACKEND will also work - but why Qt requires it to be specified by this setting instead of defaulting to it in the absence of the variable is not clear...
Turns out that for Qt of the same version on GNU/Linux there is no problem with not defining 😕 |
If you don't plan to fix None of them can be used currently, and removing them would free up 20MB (and 10MB in the ZIP file). |
|
Thanks for the tip. Using the WMF backend on windows is enough for us, so we'll remove the extra libraries. |
|
I think all can go except for libwebp-7.dll, we might want to keep that one around to to show webp images in Mudlet. |
But then you have to add Also, I didn't check the Qt-dlls before, but now I see that the following also have missing dependencies, so are currently useless: |
Brief overview of PR changes/additions
Added package
mingw-w64-x86_64-qt6-multimedia-wmfto Windows 64bits build and added enviroment variableQT_MEDIA_BACKEND=windowsin the main function (code by @SlySven).Motivation for adding to Mudlet
Solving audio problem in Windows and earning bounty
Other info (issues closed, discussion etc)
Closes #7311.
/claim #7311