Improve: Enforce Package Manager required fields#7292
Improve: Enforce Package Manager required fields#7292vadi2 merged 1 commit intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
left a comment
There was a problem hiding this comment.
Looks solid!
Are there any fields which we can remember from one package export to the next, like the author? We want to ensure that the dialog is pleasant to use each time you need to re-export a package
Author and export location would be nice. Package Manager does currently retain all information across exports, until the window is closed. |
|
I think it would be good to retain them across restarts as well. As it stands now, we are making the players job of exporting packages more difficult while there are things we can do to alleviate the pain a bit 🙂. We could store these values in settings - have a look at how the connection window uses them: https://github.com/Mudlet/Mudlet/blob/development/src/dlgConnectionProfiles.cpp#L584-L588 |
|
But I'll have a go at retaining the information firstly. |
|
Added requested saving features of author and export path. |
|
This fell through the cracks - mind resolving the conflicts so we can merge it? |
7f7181e to
e595c84
Compare
|
Ok, the conflict was due to the recent changes in file dialogs maintaining consistency across the program. So export location still confirms to this, no longer need to save this information. |
Brief overview of PR changes/additions
Modify author, title, description and version input fields to be required fields. Save author and export location fields across application restarts.
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
closes #7266
closes #2627
closes #4993