Skip to content

Improve: Enforce Package Manager required fields#7292

Merged
vadi2 merged 1 commit intoMudlet:developmentfrom
ZookaOnGit:package-exporter-7266
Dec 4, 2024
Merged

Improve: Enforce Package Manager required fields#7292
vadi2 merged 1 commit intoMudlet:developmentfrom
ZookaOnGit:package-exporter-7266

Conversation

@ZookaOnGit
Copy link
Copy Markdown
Contributor

@ZookaOnGit ZookaOnGit commented Jun 26, 2024

Brief overview of PR changes/additions

Modify author, title, description and version input fields to be required fields. Save author and export location fields across application restarts.

Motivation for adding to Mudlet

  1. Makes packages self descriptive.
  2. Will ensure compatibility with new package repository.
  3. Better user experience.

Other info (issues closed, discussion etc)

closes #7266
closes #2627
closes #4993

@ZookaOnGit ZookaOnGit requested a review from a team as a code owner June 26, 2024 06:44
@ZookaOnGit ZookaOnGit requested a review from a team June 26, 2024 06:44
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Jun 26, 2024

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

Copy link
Copy Markdown
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid!

Are there any fields which we can remember from one package export to the next, like the author? We want to ensure that the dialog is pleasant to use each time you need to re-export a package

@ZookaOnGit
Copy link
Copy Markdown
Contributor Author

Are there any fields which we can remember from one package export to the next, like the author? We want to ensure that the dialog is pleasant to use each time you need to re-export a package

Author and export location would be nice.

Package Manager does currently retain all information across exports, until the window is closed.

@vadi2
Copy link
Copy Markdown
Member

vadi2 commented Jun 27, 2024

I think it would be good to retain them across restarts as well. As it stands now, we are making the players job of exporting packages more difficult while there are things we can do to alleviate the pain a bit 🙂. We could store these values in settings - have a look at how the connection window uses them: https://github.com/Mudlet/Mudlet/blob/development/src/dlgConnectionProfiles.cpp#L584-L588

@ZookaOnGit
Copy link
Copy Markdown
Contributor Author

ZookaOnGit commented Jun 27, 2024

Also noticed that when choosing to export an update to an existing package, none of sometimes the fields are not set with any previous package information. False alarm, I cannot replicate this. Likely I was using a default installed package that doesn't have this information set.

But I'll have a go at retaining the information firstly.

@ZookaOnGit
Copy link
Copy Markdown
Contributor Author

Added requested saving features of author and export path.

@vadi2
Copy link
Copy Markdown
Member

vadi2 commented Dec 4, 2024

This fell through the cracks - mind resolving the conflicts so we can merge it?

@ZookaOnGit ZookaOnGit closed this Dec 4, 2024
@ZookaOnGit ZookaOnGit force-pushed the package-exporter-7266 branch from 7f7181e to e595c84 Compare December 4, 2024 10:41
@ZookaOnGit
Copy link
Copy Markdown
Contributor Author

Ok, the conflict was due to the recent changes in file dialogs maintaining consistency across the program. So export location still confirms to this, no longer need to save this information.

@ZookaOnGit ZookaOnGit reopened this Dec 4, 2024
@vadi2 vadi2 merged commit cc27edc into Mudlet:development Dec 4, 2024
@ZookaOnGit ZookaOnGit deleted the package-exporter-7266 branch December 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants