Fix: correct logic error that meant dodgy codepoints were always reported#7163
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Feb 27, 2024
Conversation
…rted #### Brief overview of PR changes/additions Change some boolean ORs to ANDs - making the reporting of problematic code- points much less spammy all around. #### Motivation for adding to Mudlet There is a setting so that when a codepoint is encountered by the `TTextEdit` class where there is a code-point whose width in terms of narrow or wide character is not determinable (or it does not have one) a debug message is printed to the OS command line - either just at the end of a session or for the first time this happens per codepoint per session. Unfortunately a logic error on my part in Mudlet#3832 meant that every single time such a code- point was encountered a new message was displayed. #### Other info (issues closed, discussion etc) Thanks to humera1295 (Discord user) for bringing this to my attention. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Change some boolean ORs to ANDs - making the reporting of problematic code- points much less spammy all around.
Motivation for adding to Mudlet
There is a setting so that when a codepoint is encountered by the
TTextEditclass where there is a code-point whose width in terms of narrow or wide character is not determinable (or it does not have one) a debug message is printed to the OS command line - either just at the end of a session or for the first time this happens per codepoint per session. Unfortunately a logic error on my part in #3832 meant that every single time such a code- point was encountered a new message was displayed.Other info (issues closed, discussion etc)
Thanks to humera1295 (Discord user) for bringing this to my attention.