Skip to content

Improve: add support for Unicode 14 emojis to linux#6053

Merged
vadi2 merged 1 commit intodevelopmentfrom
update-noto-color-unicode-14
Apr 11, 2022
Merged

Improve: add support for Unicode 14 emojis to linux#6053
vadi2 merged 1 commit intodevelopmentfrom
update-noto-color-unicode-14

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Apr 9, 2022 •
edited
Loading

Brief overview of PR changes/additions

Update Noto Color Emoji to the v2.034 release which supports Unicode 14.

Motivation for adding to Mudlet

So we can get these new emojis on Linux: https://emojipedia.org/unicode-14.0

Other info

See #5507 which previously updated this to Unicode 13.

@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Apr 9, 2022 •
edited
Loading

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Apr 9, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2022

Messages
✔️

PR type: Improvement

Generated by 🚫 dangerJS against 85bacaf

@vadi2 vadi2 marked this pull request as ready for review April 10, 2022 07:00
@vadi2 vadi2 requested a review from a team as a code owner April 10, 2022 07:00
@vadi2 vadi2 requested a review from a team April 10, 2022 07:00
SlySven
SlySven approved these changes Apr 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BTW (it is off-topic but related) can we bodge the FontManager class so that it only tries to load this font if it is running in Linux (or rather, if it is NOT running on Windows)? As you might know I run the same physical profiles across multiple OSes (Windows/FreeBSD/Linux) from a shared file-system and the fact that the Linux runs do put the font into the Mudlet fonts folder upsets the Windows runs when they barf over this unloadable (in that OS) font file...

I suppose I should make a PR that does this.

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Apr 11, 2022

That seems like a fine idea.

@vadi2 vadi2 merged commit 9a53109 into development Apr 11, 2022
@vadi2 vadi2 deleted the update-noto-color-unicode-14 branch April 11, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SlySven SlySven SlySven approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vadi2 @SlySven @mudlet-machine-account