Add: new function getCharacterName()#6023
Conversation
|
code looks ok to me, will hold off on approval until I can test |
|
/refresh links |
This is one portion of the stalled PR Mudlet#3952 that can be lifted from there and be implemented without raising any eyebrows (IMHO). It returns the string that the user entered into the "Character name:" field on the "Connection profile" dialogue and is needed to allow a shared module to customise its behaviour depending on the particular profile that it is being used with on the basis of the identifier being sent for login purposes - *c.f.* [`getProfileName()`](https://wiki.mudlet.org/w/Manual:Lua_Functions#getProfileName) which instead identifies the profile name which is very likely not the same text. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
4fe9228 to
5d60b1d
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
📚 Of course the documentation has already been prepared in Area51: |
|
📚 Documentation promoted from Area51 to main Wiki area. |
|
A bit early, it's not released yet! Needs to stay in area 51 until release: |
|
Reverted those changes now. |
Well, it is now out there in the PTBs so users of those might want to use it - and it did include the Mudlet release information - i.e. 4.16 and that is the next release isn't it - so no user of older versions can be in doubt why it doesn't appear in their version. As it is if we hold off on moving the documentation for functions that have been merged into the development branch than it means that everything will have to be shifted over at the point where the release is produced - and I thought you wanted to reduced the workload of doing a release... 🤷♂️ |
|
Definitely do, but not at the cost of user experience - we ought to have an automated way to transfer the functions instead: #5859 |
This is one portion of the stalled PR #3952 that can be lifted from there and be implemented without raising any eyebrows (IMHO).
It returns the string that the user entered into the "Character name:" field on the "Connection profile" dialogue and is needed to allow a shared module to customise its behaviour depending on the particular profile that it is being used with on the basis of the identifier being sent for login purposes - c.f.
getProfileName()which instead identifies the profile name which is very likely not the same text.Signed-off-by: Stephen Lyons slysven@virginmedia.com