Fix: allow the large 2D map area exit arrows to be reverted#5958
Merged
vadi2 merged 4 commits intoMudlet:developmentfrom Feb 8, 2022
Merged
Conversation
This is to allow existing map files that were not laid out to accommodate them to still use the previous smaller ones. The large arrows came about as a side effect of my adding door markings to more exits (and stubs) in Mudlet#4608. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Small arrows are now the default. The user will have to ask to use the large ones - which means that existing maps should not have an issue with the area exit arrows now - unlike as has been reported for the 4.15.0 release version. A scaling factor used with different values for small and large area exit arrows has been changed to be only generated once per call to `(void) T2DMap::paintRoomExits(...)` instead of once or twice depending on the direction of the exit in the XY-plane. A tooltip for this *knob* has been removed as it specifically mentioned the version of Mudlet that introduced the large area exits - and it doesn't need to now the default is pretty much as Mudlet would have been before that version. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2
approved these changes
Feb 8, 2022
Member
vadi2
left a comment
There was a problem hiding this comment.
Nice, works and default is small as before.
Peek.2022-02-08.12-41.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to allow existing map files that were not laid out to accommodate them to still use the previous smaller ones.
The large arrows came about as a side effect of my adding door markings to more exits (and stubs) in #4608.
This should close #5945. Whilst hunting down this issue I found that the method
void T2DMap::paintAreaExits(...)actually draws ALL the room exits - so I took the liberty of renaming it to:void T2DMap::paintRoomExits(...). That method also contained some local variables that had names beginning with the_character - this is not recommended - even if it is not followed by the reserved cases of another one or an UPPER-case letter - I've also fixed those.Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
Fix: allow for larger area exit arrows introduced as part of Mudlet 4.15.0 to be changed back to something like they were before then - so that existing maps that were not laid out to accommodate them can continue to be usable.