Skip to content

Infrastructure: untangle strings for translation#5556

Merged
Kebap merged 5 commits intoMudlet:developmentfrom
Kebap:fix_translatability
Aug 12, 2022
Merged

Infrastructure: untangle strings for translation#5556
Kebap merged 5 commits intoMudlet:developmentfrom
Kebap:fix_translatability

Conversation

@Kebap
Copy link
Copy Markdown
Contributor

@Kebap Kebap commented Oct 29, 2021

Brief overview of PR changes/additions

Reduce repetition and number of strings for translation work

Motivation for adding to Mudlet

Before:

  • image

After:

  • Entered number is invalid.
  • Set the number of the room northwest of this one.
  • Set the number of the room north of this one.
    etc.

Other info (issues closed, discussion etc)

Original texts stem from #5513

Release post highlight

@Kebap Kebap requested a review from a team as a code owner October 29, 2021 11:25
@Kebap Kebap requested a review from a team October 29, 2021 11:25
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Oct 29, 2021

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2
Copy link
Copy Markdown
Member

vadi2 commented Oct 29, 2021

Agreed - we have to be mindful of the volunteer translators time and effort.

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vadi2 vadi2 added the hacktoberfest-accepted Not yet merged, but a welcome addition already! :-) label Oct 30, 2021
Copy link
Copy Markdown
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit dubious of breaking what was a single sentence up into what is now going to be two paragraphs - but if it makes other people happy I guess I can live with it...

🤷‍♂️

@mudlet-machine-account mudlet-machine-account added this to the 4.17.0 milestone Aug 12, 2022
@Kebap Kebap merged commit 7eb79b3 into Mudlet:development Aug 12, 2022
@Kebap Kebap deleted the fix_translatability branch August 12, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Not yet merged, but a welcome addition already! :-)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants