Improve: cleanup room_exits.ui file#5512
Merged
SlySven merged 2 commits intoMudlet:developmentfrom Oct 14, 2021
Merged
Conversation
This reorders the elements of two (nested as it happens) `QGridLayout`s so that their elements are in ascending row then column order. It also converts another one that only contains a single element to a `QVBoxLayout`. This is so that a change to be made by another PR that will also be extracted from the draft PR Mudlet#5308 is easier to review. This PR should not produce any functional changes. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
6 tasks
I confounded the `class` attribute and the `name` one. Whilst a name is not essential it can help when hand (well in a text editor) editing a `.ui` file! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2
approved these changes
Oct 14, 2021
Member
vadi2
left a comment
There was a problem hiding this comment.
I'd like a cleanup of a different kind - the visual 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorders the elements of two (nested as it happens)
QGridLayouts so that their elements are in ascending row then column order. It also converts another one that only contains a single element to aQVBoxLayout. This is so that a change to be made by another PR that will also be extracted from the draft PR #5308 is easier to review.This PR should not produce any functional changes.
Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
None!