BugFix: repair "prevent all controls from being hidden" feature#5445
Conversation
It seems, *I think* that the removal of the "default host" profile (in Mudlet#2950) broke the logic that detected that any "real" profiles were loaded and prevented both the main menu bar and the main toolbar from being hidden when no such profiles were active. As it is now it is not possible to hide both the main menu and the main toolbar AFTER a profile is loaded - even though we provide the settings that are suppose to allow that. The original `enum` used to encode the wanted settings for the visibility of those two items used a cunning combination of bit patterns (and some application of DeMorgan's laws) to work out what the visibility settings are and what state the application is in (number of profiles active) so as to show or hide the main menu and main toolbars. Unfortunately I've lost track of how I put it together when the single "default host" profile was included in the count so had to rewrite the logic tests without changing the `enum` values. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Marking this as a medium bugfix as it is not fatal to the application - but a pain if you want to hide both the menu and the toolbar. Current development code - showing the main toolbar when it should be hidden: Same code and settings when "cancel" is clicked on the "Connection Preferences" dialogue at startup and the main toolbar is hidden by right-clicking on it and unchecking it on the built-in context menu: Note that this was brought to my attention by the Discord user jbear#9576 in the #help channel:
...
|
It seems, I think that the removal of the "default host" profile (in #2950) broke the logic that detected that any "real" profiles were loaded and prevented both the main menu bar and the main toolbar from being hidden when no such profiles were active. As it is now it is not possible to hide both the main menu and the main toolbar AFTER a profile is loaded - even though we provide the settings that are suppose to allow that.
The original
enumused to encode the wanted settings for the visibility of those two items used a cunning combination of bit patterns (and some application of DeMorgan's laws) to work out what the visibility settings are and what state the application is in (number of profiles active) so as to show or hide the main menu and main toolbars. Unfortunately I've lost track of how I put it together when the single "default host" profile was included in the count so had to rewrite the logic tests without changing theenumvalues.Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
You can now hide both the Main Menu and Toolbar (after a profile is loaded) again.