Fix Windows builds & update dependencies#5329
Closed
vadi2 wants to merge 1 commit intoMudlet:developmentfrom
Closed
Fix Windows builds & update dependencies#5329vadi2 wants to merge 1 commit intoMudlet:developmentfrom
vadi2 wants to merge 1 commit intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
Updating to latest vcpkg is still not possible due to microsoft/vcpkg#17374, will try using an older cmake instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Fix Windows builds by updating to latest vcpkg, which resolves a bad interaction between latest cmake, github actions and vcpkg.
Updating our vcpkg subrepo will also update the dependencies used for macOS and Linux builds.
Motivation for adding to Mudlet
Fix Github Actions windows builds - https://github.com/Mudlet/Mudlet/runs/3152971871?check_suite_focus=true
Other info (issues closed, discussion etc)
See lukka/run-vcpkg#88 (comment)
Release post highlight