Skip to content

Update autocompletion data in Mudlet#5278

Closed
github-actions[bot] wants to merge 3 commits intodevelopmentfrom
update-autocompletion-data-0ee7678be8d7a5f0db5d8ac2d90ffe3541e46b53
Closed

Update autocompletion data in Mudlet#5278
github-actions[bot] wants to merge 3 commits intodevelopmentfrom
update-autocompletion-data-0ee7678be8d7a5f0db5d8ac2d90ffe3541e46b53

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jun 7, 2021

Brief overview of PR changes/additions

👑 An automated PR to update autocompletion data in Mudlet from refs/heads/development (0ee7678).

Motivation for adding to Mudlet

So autocompletion works as expected.

@add-deployment-links
Copy link
Copy Markdown

add-deployment-links Bot commented Jun 7, 2021

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@Kebap
Copy link
Copy Markdown
Contributor

Kebap commented Jun 7, 2021

Manually triggered update, as we were accidentally promoting a non-existing function deleteCmdLineSuggestion which is actually called removeCmdLineSuggestion

Please green-light for quick bugfix

Proof:

Mudlet/src/TLuaInterpreter.cpp

Lines 13636 to 13638 in 0ee7678

lua_register(pGlobalLua, "addCmdLineSuggestion", TLuaInterpreter::addCmdLineSuggestion);
lua_register(pGlobalLua, "removeCmdLineSuggestion", TLuaInterpreter::removeCmdLineSuggestion);
lua_register(pGlobalLua, "clearCmdLineSuggestions", TLuaInterpreter::clearCmdLineSuggestions);

@Kebap Kebap added the bugfix label Jun 7, 2021
@Kebap Kebap enabled auto-merge (squash) June 7, 2021 22:40
@Kebap
Copy link
Copy Markdown
Contributor

Kebap commented Jun 11, 2021

For some reason, the bot now decided to continue in a new PR #5283 instead 🤷

@Kebap Kebap closed this Jun 11, 2021
auto-merge was automatically disabled June 11, 2021 11:44

Pull request was closed

@vadi2 vadi2 deleted the update-autocompletion-data-0ee7678be8d7a5f0db5d8ac2d90ffe3541e46b53 branch September 5, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants