Allow profile tab bars to be moved around#4790
Allow profile tab bars to be moved around#4790vadi2 wants to merge 2 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
src/dlgMapper.cpp
Outdated
|
|
||
| void dlgMapper::updateInfoContributors() | ||
| { | ||
| return; |
There was a problem hiding this comment.
Accidental commit to work around the crash
| mpTabBar->setTabsClosable(true); | ||
| mpTabBar->setAutoHide(true); | ||
| connect(mpTabBar, &QTabBar::tabCloseRequested, this, &mudlet::slot_close_profile_requested); | ||
| // TODO: Do not enable this option currently - although the user can drag |
There was a problem hiding this comment.
I remember vivid discussion in the original pr hence the temporary deactivation here. The pr number eludes me. May be worthwhile to review
There was a problem hiding this comment.
Seems to work OK in testing
There was a problem hiding this comment.
Please click multiplay button to see 2 or 3 profiles simultaneously, then move the headers around
There was a problem hiding this comment.
🤦♂️ Um, that was why I left the comment there...
|
This does not work with multiview. |
Brief overview of PR changes/additions
Allow profile tab bars to be moved around
Motivation for adding to Mudlet
For player convenience
Other info (issues closed, discussion etc)
The comment that was added was incorrect - the underlying console does move around OK.