Skip to content

(the_merge) Resolve conflicts in src/CMakeLists.txt [ci skip]#443

Merged
SlySven merged 1 commit intodevelopment_merge_30from
vadi2-patch-2
Mar 27, 2017
Merged

(the_merge) Resolve conflicts in src/CMakeLists.txt [ci skip]#443
SlySven merged 1 commit intodevelopment_merge_30from
vadi2-patch-2

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Mar 27, 2017

No description provided.

@vadi2 vadi2 requested a review from SlySven March 27, 2017 06:22
@vadi2 vadi2 changed the title Resolve conflicts in src/CMakeLists.txt [ci skip] (the_merge) Resolve conflicts in src/CMakeLists.txt [ci skip] Mar 27, 2017
# Copyright (C) 2015-2016 by Stephen Lyons - slysven@virginmedia.com #
=======
# Copyright (C) 2015 by Stephen Lyons - slysven@virginmedia.com #
>>>>>>> SlySven/release_30
Copy link
Copy Markdown
Member

@SlySven SlySven Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case my Repo is being taken in vain, my release_30 branch is synced to the Mudlet/release_30 at this point, they are both on the same SHA1 here. So just because there is a change to merge, that does not mean I am responsible for it. Like the other change below, that is not my handiwork.

@SlySven
Copy link
Copy Markdown
Member

SlySven commented Mar 27, 2017

How is this going to proceed, the command to skip the CI process finally seems to have taken, but the absence of the CI seems to also allow merging without approval - or is that because it is you, Vadim, positing this PR? 😕

UPDATE: CI is pointless until we get all the merge conflict markers removed by selecting which bits to use.

@keneanung
Copy link
Copy Markdown
Member

I believe this is because the target branch is not "protected".

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Mar 27, 2017

development_merge_30 is not a protected by CI branch. I'll add protection by reviewers though.

Copy link
Copy Markdown
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting into the hang of how this will work.

@SlySven SlySven merged commit f2fcac3 into development_merge_30 Mar 27, 2017
@vadi2 vadi2 deleted the vadi2-patch-2 branch March 27, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants