Sync mudlet-lua to 9f9248fdb2900f695cb6df7a99bbcbd2135dab55#415
Merged
vadi2 merged 1 commit intoMudlet:release_30from Mar 13, 2017
Merged
Sync mudlet-lua to 9f9248fdb2900f695cb6df7a99bbcbd2135dab55#415vadi2 merged 1 commit intoMudlet:release_30from
vadi2 merged 1 commit intoMudlet:release_30from
Conversation
SlySven
approved these changes
Mar 10, 2017
Member
SlySven
left a comment
There was a problem hiding this comment.
I see that the first file's change fixes the typo in the other PR. 😄
Cannot offer an opinion about other two but trust they are good. 😐
Member
|
|
Member
Author
|
It didn't matter either way it seems because this PR didn't touch that particular line. Will send a follow-up PR. |
Member
|
That's why you didn't get a conflict, which was my point. We wouldn't have noticed the erroneous |
Member
Author
|
Makes sense, thanks for the heads up on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need another sync as a complement to #414. Has a couple of bugfixes that have happened to mudlet-lua since then.