Revise: change method to calculate translation statistics#3877
Closed
SlySven wants to merge 2 commits intoMudlet:developmentfrom
Closed
Revise: change method to calculate translation statistics#3877SlySven wants to merge 2 commits intoMudlet:developmentfrom
SlySven wants to merge 2 commits intoMudlet:developmentfrom
Conversation
Recently some change at CrowdIn has resulted in the translation files all having text assigned to the translation (output) element in the `mudlet_xx_YY.ts` files - even if it is the original source text. This means that `lrelease` will not longer generate extra lines warning about untranslated source texts and we have to switch to counting the texts that are "finished" instead. Just in case things change again, a warning message will be printed out should those messages reoccur. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Kebap
reviewed
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently some change at CrowdIn has resulted in the translation files all having text assigned to the translation (output) element in the
mudlet_xx_YY.tsfiles - even if it is the original source text. This means thatlreleasewill not longer generate extra lines warning about untranslated source texts and we have to switch to counting the texts that are "finished" instead.Just in case things change again, a warning message will be printed out should those messages reoccur.
This is urgent as it needs to be in for the next release which is imminent - it closes #3779 .
Signed-off-by: Stephen Lyons slysven@virginmedia.com