Skip to content

Add Lua tests to CI#3795

Merged
vadi2 merged 87 commits intodevelopmentfrom
add-busted-in-ci
Sep 30, 2021
Merged

Add Lua tests to CI#3795
vadi2 merged 87 commits intodevelopmentfrom
add-busted-in-ci

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented May 16, 2020

Brief overview of PR changes/additions

This PR completes the work of running our nearly 200 Busted-based tests to run in CI automatically on every change, and complements the existing C++ tests which are run automatically already.

Motivation for adding to Mudlet

Better Mudlet quality!

Other info (issues closed, discussion etc)

We need to add a lot more tests to Lua to cover many aspects of the API =)

@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented May 16, 2020

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

# Conflicts:
#	.github/workflows/build-mudlet.yml
@demonnic
Copy link
Copy Markdown
Member

I have some changes to the run test xml I need to get pushed up to git, will try to do that today

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Aug 29, 2021

I've got the final part squared as away as well. It works!

image

Expanding the previous step, you see the issue...

image

😃

@vadi2 vadi2 marked this pull request as ready for review September 28, 2021 19:45
@vadi2 vadi2 requested a review from a team as a code owner September 28, 2021 19:46
@vadi2 vadi2 requested review from a team September 28, 2021 19:46
Copy link
Copy Markdown
Member

@demonnic demonnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Sep 29, 2021

@Chris7

@demonnic
Copy link
Copy Markdown
Member

hmm, it seems to think there's a status still missing. If ubuntu/gcc replaced by or supplemented by ubuntu/gcc/lua tests?

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Sep 29, 2021

Replaced - github was confused because we marked ubuntu / gcc as a mandatory one in settings, but it won't run in this workflow anymore. I've removed it for the time being, and after we merge this PR, we can add ubuntu / gcc / lua tests as a mandatory one back again.

It'll mean that any existing PRs will need to be updated with development once that happens, but that is simple to do.

@demonnic
Copy link
Copy Markdown
Member

ok cool, that's what I thought might be the case.

@vadi2 vadi2 merged commit ebd698e into development Sep 30, 2021
@vadi2 vadi2 deleted the add-busted-in-ci branch September 30, 2021 07:56
@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Sep 30, 2021

@LiamLeFey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants