(release_30) sound updates - bugfix and enhance#359
(release_30) sound updates - bugfix and enhance#359SlySven merged 3 commits intoMudlet:release_30from
Conversation
This moves sound from 4 static players into an unlimited QList, fixing https://bugs.launchpad.net/mudlet/+bug/1645064 It also adds volume (0-100) to the LUA playSoundFile command, with 100 (maximum) substituted if not present for backwards compatability.
|
|
|
We've also frozen release_30 from getting new features, in an attempt to stem the flow of bugs resulting from them - so we can finally get 3.0 out the door... let's keep the improvement to development branch only. |
|
Sorry, I shouldn't have created release30 and dev commits at the same time with this. It's not really new features as much as a bug fix, it just happened that the easiest way to stop mudlet from crashing when you play 5 sounds simultaneously was to remove the limit. Adding volume at the same time (in lua) was only a line or two. |
corrected location of comment
|
❓ I must confess that I did not get a crash on my Linux system with more than 4 sounds trying to be played, I think I got the most recently started sound being changed as expected from the existing code... |
|
Taking another look, the sample code I used identifying this now works? |
vadi2
left a comment
There was a problem hiding this comment.
Works fine, thanks @Nyyrazzilyss!
|
@SlySven I didn't get a crash either, but it adds the feature of more simultaneous sounds which is cool. Over to you |
|
👍 So I'll hit the switch... buzz |
|
...ouch! I deeply regret that I messed things up here because I didn't spot that there are things here that match items on the development branch version of this PR. Although I have immediately reverted the change it has killed this PR as there isn't a way to "undo" the merge AND reactivate this PR. @Nyyrazzilyss I think we need to resolve the error message presentation thing on #358 and any other concerns relevant to this branch and then you can re-PR a cleaned up single commit with all the right bits and none of the not-right bits based on top of the most up to date version of the release_30 branch as a new PR... |
|
No problem, creating this at the same time I created the development branch pr was an error on my part in the first place. |
This moves sound from 4 static players into an unlimited QList,
fixing https://bugs.launchpad.net/mudlet/+bug/1645064
It also adds volume (0-100) to the LUA playSoundFile command, with 100
(maximum) substituted if not present for backwards compatability.