Increasing code coverage for Other.lua#3414
Merged
demonnic merged 2 commits intoMudlet:developmentfrom Mar 10, 2020
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
reviewed
Mar 10, 2020
vadi2
reviewed
Mar 10, 2020
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Adds 25 new tests against functions from Other.lua. Documents a todo list at the bottom of the spec file for the functions (as of the time of this PR) which are not covered by tests.
Motivation for adding to Mudlet
Making Mudlet and its releases less fragile. Yay testing.
Other info (issues closed, discussion etc)
Also exposed the first bug using the tests, it seems.