BugFix: handle end of line better for selection by mouse#3125
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Oct 11, 2019
Merged
Conversation
This should close Mudlet#3064 and close Mudlet#3083 and also close Mudlet#3097 ! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
If the issues concerned are so much of an issue then I guess this might warrant a 4.2.3 patch release...! 😄 |
vadi2
reviewed
Sep 24, 2019
Member
vadi2
left a comment
There was a problem hiding this comment.
Sorry it looks like my review didn't come through - but selection still has a noticeable problem, if you accidentally select a line above or below - which is super easy to do - it doesn't unselect:
Member
Author
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #3064 and close #3083 and also close #3097 !
It does mean that clicking and then dragging from a point beyond the end of the line will select the last grapheme on the line as the start point for the selection - which might not quite what is wanted (which could be to start the selection at the start of the next line if it becomes a downward drag) but it does clear up all those other issues...
Signed-off-by: Stephen Lyons slysven@virginmedia.com