Fix Chinese text selection#2790
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
Chinese selection works fine, tab selection does not - upon inspection current display of tabs in Mudlet is even more broken than before. Compare:
Mudlet:
I'll look into tab display and selection in another PR, as that's an entire subject of its own. |
|
Feedback is positive from two users so far:
Tab selection doesn't work right, but that is a separate issue as tab display itself doesn't even work right. |
Kebap
left a comment
There was a problem hiding this comment.
Looks Good To Me
Let's Get This Merged
| int x = event->x() / mFontWidth; | ||
| if (mShowTimeStamps) { | ||
| if (x < 13) { | ||
| mCtrlSelecting = true; |
There was a problem hiding this comment.
Removing this line of code(and the conditional path to it) is presumably what broke timestamp selection. Probably could be re-implemented pretty easily.
Brief overview of PR changes/additions
Before:
After:
Motivation for adding to Mudlet
i18n goals, fix #1825.
Other info (issues closed, discussion etc)
I'm not entirely happy with the new function naming - ideas welcome... the important method is
convertMouseXToBufferX()which dynamically calculates the actual character index instead of assuming all characters are width 1 as before.Things to test: