Fix extra height appearing in the input line#2725
Fix extra height appearing in the input line#2725vadi2 wants to merge 3 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
And how do you adjust? |
|
I assume you aren't seeing the same result because your input line height is not set lower than your font height. |
|
Sorry, what do you mean? |
|
Ah - it's not cut off, there is literally 0 padding. If you have a very close look, that So perhaps we should add some padding on the bottom, because the initial impressions were that it was broken. |
|
Aha! Yes, definitely. Thanks for taking the time to write up the explanation. |
|
I've spent close to 15 hours on this which is way too much. That option we have makes things super difficult because there is not enough information available - that's why current code just did lines+1 and why you saw the extra space. So the next question is to ask - is the option useful? Does anyone actually want to display 2,3,4 lines at a time always? Or should we have it automatically grow as needed and allow the person to cap it at a certain maximum instead? |







Brief overview of PR changes/additions
Fix extra height appearing in the command line at font size 12 and above.
Motivation for adding to Mudlet
Small aesthetic details like this matter.
Other info (issues closed, discussion etc)