Skip to content

Fix selectSection not accepting main and returning wrong value#2000

Merged
vadi2 merged 1 commit intoMudlet:developmentfrom
vadi2:fix-selectstring
Sep 26, 2018
Merged

Fix selectSection not accepting main and returning wrong value#2000
vadi2 merged 1 commit intoMudlet:developmentfrom
vadi2:fix-selectstring

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Sep 25, 2018

Brief overview of PR changes/additions

Fix selectSection not accepting main and returning wrong value, as well as bring the error messages up to modern standards for Mudlet.

Motivation for adding to Mudlet

Better user experience

Other info (issues closed, discussion etc)

Fix #1999

@vadi2 vadi2 added this to the 3.14 milestone Sep 25, 2018
@vadi2 vadi2 requested a review from a team as a code owner September 25, 2018 16:24
@vadi2 vadi2 requested review from a team September 25, 2018 16:24
@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Sep 25, 2018

jor'mox Сегодня в 19:01
Seems to be working both ways. "main" is now a valid window, and random window names return false when I try to select from them.

@keneanung keneanung removed their assignment Sep 25, 2018
@vadi2 vadi2 merged commit c3eaa44 into Mudlet:development Sep 26, 2018
@vadi2 vadi2 deleted the fix-selectstring branch September 28, 2018 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

selectSection window errors

2 participants