Fix: crash on Alt+w when closing multiple profiles at once#8301
Fix: crash on Alt+w when closing multiple profiles at once#8301vadi2 merged 1 commit intoMudlet:developmentfrom
Conversation
vadi2
left a comment
There was a problem hiding this comment.
Unfortunately, this still crashes. To test, try it in a Linux VM.
|
This was in the end fixed by #8203, thank you for giving this a go! |
|
There is still a crash when closing a profile, even after PR #8203. The crash produces the same segmentation fault message as reported in the original issue #7478. Step to reproduce the crash: Hold ALT + W while opening a profile. Demonstration: video Analysis: PS: My work for this issue has always been done on Linux. |
vadi2
left a comment
There was a problem hiding this comment.
Yep, it's a different reproduction scenario but a related crash fix nonetheless, thanks for covering it!
|
/tip $100 @NicolasKeita |
|
Please visit Algora to complete your tip via Stripe. |
|
🎉🎈 @NicolasKeita has been awarded $100 by Mudlet! 🎈🎊 |
Brief overview of PR changes/additions
Closing a game while it is still loading causes a crash.
Details
Closing the MUD would immediately set mpHost to nullptr, while Host::loadingMap() and mudlet::slot_connectionDialogueFinished() are still actively using it.ALT + W.ALT + Wpressed.Tests
Manual test :
screencast of the fix :
Fix demonstration video
AppImage :
Download
Automatic tests :
mudletandHostclasses) to the project would be beneficial for preventing regressions./claim #7478
Fixes #7478