Skip to content

setPopup api broken #4641

@Kebap

Description

@Kebap

Brief summary of issue / Description of requested feature:

something must have gone wrong during earlier refactorization

Steps to reproduce the issue / Reasons for adding feature:

  1. code expects window name, if more than 4 arguments received, but docs explain 2-3 arguments
  2. second argument (or first if no window name given) will be a string called "text", but it is never used after that.
  3. This hints at a copy/paste error with putPopup which actually has a text argument and uses it as well, whereas setPopup operates on the prior selected text.

Error output / Expected result of feature

Probably just drop "text" argument, but not sure if I understand and untangle the history of this function alright.

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Seems to relate back to the changes by @smurfix some months ago

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions