Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.60%. Comparing base (28bc599) to head (02691f3).
Report is 336 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #9306      +/-   ##
==========================================
+ Coverage   89.82%   90.60%   +0.77%     
==========================================
  Files         412      403       -9     
  Lines       11878    12661     +783     
  Branches     2364     2447      +83     
==========================================
+ Hits        10670    11472     +802     
+ Misses        681      633      -48     
- Partials      527      556      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi,
Thanks for the PR.
Unfortunately, this would be a breaking change. You either need to call InvokeAsync without awaiting it, or this PR will have to stay on hold.

Thanks,But I guess it will cause other bugs if i call InvokeAsync without awaiting it

Maybe we can make the change in an unbreaking way. How about adding public event Func<IDialogReference, Task>? DialogInstanceAdded; (Note: without the On prefix, which I think should not be added to events anyway) without changing the existing OnDialogInstanceAdded and marking it [Obsolete("Please use DialogInstanceAdded instead!")]

Of course both need to be fired for backwards compatibility. Either that or we don't change the event signature and fire it only after awaiting.

thanks for your suggestions,i will try to make the change,by the way,how to test it?

Not sure if it can be tested

Do you have an example of code when you get that exception?

dialogReference = dialog.Show<T>(title, parameters, options);
dialog is IDialogService
open two windows in browser,each window open a same dialog,it reports
The current thread is not associated with the Dispatcher. Use InvokeAsync() to switch execution to the Dispatcher when triggering rendering or component state
the stacktrace points to the function StateHasChanged in function AddInstance,
it works for me if i write code like this
await InvokeAsync(() => dialogReference = dialog.Show<T>(title, parameters, options))

I found the problem,the dialog parameter is a singleton,it causes some errors when opening multiple windows

I found the problem,the dialog parameter is a singleton,it causes some errors when opening multiple windows

Do you mean if you reuse existing DialogParameters it will cause problem?

yes

Maybe we can make the change in an unbreaking way. How about adding public event Func<IDialogReference, Task>? DialogInstanceAdded; (Note: without the On prefix, which I think should not be added to events anyway) without changing the existing OnDialogInstanceAdded and marking it [Obsolete("Please use DialogInstanceAdded instead!")]

Of course both need to be fired for backwards compatibility. Either that or we don't change the event signature and fire it only after awaiting.

Did in a non breaking fashion. I tried to write a test, that would create dialog in a non UI thread but in bUnit it still passes regardless, so I guess let's continue without a test.

I tried to write a test, that would create dialog in a non UI thread but in bUnit it still passes regardless, so I guess let's continue without a test.

Nvm, I wrote a test that seems to work. If we remove the return InvokeAsync(StateHasChanged); it will crash somewhere and the invoked = true will not fire.

Related: https://discord.com/channels/786656789310865418/786656789310865422/1261308771020570695

Awesome! Thank you both!