Skip to content

Rollback mostro-cor to Nostr sdk 0.38#93

Merged
grunch merged 2 commits into
mainfrom
rollback-sdk-0-38
Mar 21, 2025
Merged

Rollback mostro-cor to Nostr sdk 0.38#93
grunch merged 2 commits into
mainfrom
rollback-sdk-0-38

Conversation

@arkanoider

@arkanoider arkanoider commented Mar 21, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

@grunch ,

this is the best thing I had in mind, i know you won't like it, but to merge disputes at the moment let's roll back to 0.38.
Modification are trivial as you can see, basically just that xonly() introduced by Yuki in sdk 0.39.

I am preparing also a small project just to test the signature issue with both version and I spoke also with yuki about.
In any case we have to find out the issue to move on with sdk versions, but for now let's add disputes with 0.38 as we said yesterday.

I did not touch version here so it's 6.32. I let you decide if you want to move 6.33 or not.

Summary by CodeRabbit

We’ve made behind‐the‐scenes improvements for a more reliable experience.

  • Chores
    • Adjusted dependency management by switching to an earlier stable version of a key library, ensuring consistent performance.
  • Refactor
    • Streamlined the signature verification process to yield a more direct and dependable outcome for users.

These enhancements maintain functionality while bolstering overall efficiency and stability.

@coderabbitai

coderabbitai Bot commented Mar 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request introduces two changes. First, the nostr-sdk dependency in the Cargo.toml file is downgraded from version 0.39.0 to 0.38.0. Second, the verify_signature method in the src/message.rs file has been refactored to directly call the verify method on pubkey, removing the intermediate xonly() call and reducing optional handling.

Changes

File Change Summary
Cargo.toml Downgraded nostr-sdk dependency version from 0.39.0 to 0.38.0.
src/message.rs Simplified verify_signature by removing the xonly() call and mapping, now using a direct call to verify.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Message
    participant PubKey

    Caller->>Message: Call verify_signature(message, signature)
    Message->>PubKey: Invoke verify(message, signature)
    PubKey-->>Message: Return boolean result
    Message-->>Caller: Return verification result
Loading

Suggested reviewers

  • grunch

Poem

I'm a rabbit hopping through the code,
Skipping past branches in my humble abode.
I nibbled away at extra hops in the verifications,
Simplified paths and neat revisions.
With a twitch and a hop, my joy does explode!
Carrots and code — a whimsical ode!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0e4c4e and 21f49c2.

📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • src/message.rs (1 hunks)
🔇 Additional comments (2)
Cargo.toml (1)

35-35: Dependency downgrade to nostr-sdk 0.38.0 confirmed

This change correctly implements the rollback from nostr-sdk 0.39.0 to 0.38.0 as intended in the PR objectives. The downgrade is necessary to address signature verification issues mentioned in the PR description.

src/message.rs (1)

207-207: Signature verification logic simplified correctly

The signature verification logic has been appropriately simplified by removing the xonly() function call that was introduced in nostr-sdk 0.39. This change maintains the same security guarantees while ensuring compatibility with version 0.38 of the SDK.

The direct call to verify method on the pubkey is the correct approach for version 0.38, as it handles the verification in a more straightforward manner without the intermediate optional handling.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arkanoider arkanoider requested review from Catrya and grunch March 21, 2025 09:33
@arkanoider arkanoider mentioned this pull request Mar 21, 2025
Merged
grunch
grunch approved these changes Mar 21, 2025
View reviewed changes

@grunch grunch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's do it

@grunch grunch merged commit a27bf58 into main Mar 21, 2025
@grunch grunch deleted the rollback-sdk-0-38 branch March 21, 2025 15:36
@coderabbitai coderabbitai Bot mentioned this pull request Mar 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunch grunch grunch approved these changes

@Catrya Catrya Awaiting requested review from Catrya

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkanoider @grunch