Skip to content

New UserInfo message struct#100

Merged
grunch merged 2 commits into
developfrom
user-info-message
Apr 14, 2025
Merged

New UserInfo message struct#100
grunch merged 2 commits into
developfrom
user-info-message

Conversation

@arkanoider

@arkanoider arkanoider commented Apr 12, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

@grunch @Catrya

Changed name as correctly pointed out by @grunch to USerInfo to avoid misunderstanding in maker info message.

Summary by CodeRabbit

  • New Features

    • Introduced an updated user profile model with refined details for ratings, review counts, and operating history, providing a clearer overview of user performance.

  • Refactor

    • Harmonized the presentation of user information in dispute handling and messaging workflows for a consistent and seamless experience.

@coderabbitai

coderabbitai Bot commented Apr 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes refactor the code by replacing the UserDisputeInfo type with a new UserInfo struct. In dispute.rs, the fields initiator_info and counterpart_info in SolverDisputeInfo are updated to use Option<UserInfo>, along with corresponding constructor adjustments. In message.rs, the Peer struct’s reputation field and related methods and tests are modified to reference UserInfo instead of UserDisputeInfo. Additionally, a new public UserInfo struct is introduced in user.rs with fields for rating, reviews, and operating_days.

Changes

File(s) Change Summary
src/dispute.rs, src/message.rs Replaced all usages of UserDisputeInfo with UserInfo: In dispute.rs, updated SolverDisputeInfo fields and constructor; in message.rs, modified Peer struct, its constructor, and tests.
src/user.rs Added new public struct UserInfo with fields: rating: f64, reviews: i64, and operating_days: u64, along with trait derivations for Debug, Default, Deserialize, Serialize, and Clone.

Poem

I hop through the lines of code today,
A brand new struct leads the way.
Old names retire with a gentle sigh,
As UserInfo hops in, crisp and spry.
With whiskers twitching in pure delight,
I celebrate every change in plain sight!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad07d70 and 052d522.

📒 Files selected for processing (3)
  • src/dispute.rs (4 hunks)
  • src/message.rs (4 hunks)
  • src/user.rs (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/message.rs (2)
src/user.rs (1)
  • new (38-60)
src/dispute.rs (2)
  • new (114-175)
  • new (179-191)
🔇 Additional comments (10)
src/user.rs (1)

6-15: Good addition of the new UserInfo struct

The new UserInfo struct is well-designed with appropriate fields for user reputation metrics, and includes good documentation comments for each field. The struct correctly uses derive macros for common traits needed for serialization and debugging.

This change effectively replaces the previous UserDisputeInfo struct with a more generally named UserInfo struct, which should help prevent confusion with maker info messages as mentioned in the PR objectives.

src/dispute.rs (3)

1-1: Updated import correctly

The import has been properly updated to use the new UserInfo struct from the user module.

99-100: Field types updated correctly

The field types in SolverDisputeInfo struct have been properly updated from Option<UserDisputeInfo> to Option<UserInfo>, maintaining the same optionality.

130-144: Constructor implementation updated correctly

The construction of the UserInfo instances in the SolverDisputeInfo::new method has been properly updated to use the new struct name while maintaining the same field assignments.

src/message.rs (6)

3-3: Import updated correctly

The import statement has been properly updated to use the new UserInfo struct.

25-25: Field type updated correctly

The reputation field type in the Peer struct has been properly updated from Option<UserDisputeInfo> to Option<UserInfo>.

29-29: Method signature updated correctly

The new method signature has been properly updated to use Option<UserInfo> instead of Option<UserDisputeInfo>.

432-432: Test import updated correctly

The test import has been properly updated to use UserInfo instead of UserDisputeInfo.

440-444: Test data updated correctly

The test data instantiation has been properly updated to use UserInfo instead of UserDisputeInfo, maintaining the same field values and test logic.

499-503: Second test data instance updated correctly

The second test data instantiation has been properly updated to use UserInfo instead of UserDisputeInfo, maintaining the same field values and test logic.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arkanoider arkanoider requested review from Catrya and grunch April 12, 2025 07:21
@arkanoider arkanoider mentioned this pull request Apr 12, 2025
Merged
grunch
grunch approved these changes Apr 14, 2025
View reviewed changes

@grunch grunch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@grunch grunch merged commit b814bd1 into develop Apr 14, 2025
@grunch grunch deleted the user-info-message branch April 14, 2025 21:31
@coderabbitai coderabbitai Bot mentioned this pull request Apr 16, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Oct 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunch grunch grunch approved these changes

@Catrya Catrya Awaiting requested review from Catrya

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkanoider @grunch