Walkthrough

Consolidates dispute initiator/counterpart selection in admin_take_dispute_action to a three-way match on seller_dispute/buyer_dispute, with early error on invalid combinations. Replaces order_creator_tradekey usage with dispute_initiator in SolverDisputeInfo. Minor formatting-only refactor in db::is_dispute_taken_by_admin without logic changes.

Changes

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Admin
  participant App as App (admin_take_dispute_action)
  participant DB

  Admin->>App: Take dispute request
  App->>DB: (Optional) is_dispute_taken_by_admin(order_id)
  DB-->>App: Boolean/Option

  App->>App: Read order.seller_dispute, order.buyer_dispute
  alt seller_dispute = true && buyer_dispute = false
    Note right of App: Initiator = seller<br/>Counterpart = buyer
    App->>App: Build SolverDisputeInfo(dispute_initiator)
    App-->>Admin: Proceed with dispute handling
  else buyer_dispute = true && seller_dispute = false
    Note right of App: Initiator = buyer<br/>Counterpart = seller
    App->>App: Build SolverDisputeInfo(dispute_initiator)
    App-->>Admin: Proceed with dispute handling
  else invalid combination
    Note right of App: Early return error
    App-->>Admin: DisputeEventError
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Refactoring code removing unwraps() #449: Touches the same admin_take_dispute_action, adjusting error handling; overlaps with current control-flow changes.
• Feature disputes #463: Revises initiator/counterpart determination and SolverDisputeInfo construction in the same function.
• refactor: remove deprecated token columns from disputes table #516: Modifies dispute payload shape and SolverDisputeInfo inclusion within admin_take_dispute.rs.

Suggested reviewers

• Catrya
• grunch

Poem

I thump my paws—disputes in line,
Two flags decide whose claim to sign.
If seller squeaks, or buyer squeals,
I pick the path, no wobbly wheels.
Early hop when states don’t match—
Clean tracks laid down—dispatch! 🐇✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

plomo al hampa plo plo plo!

Don't know what that means, but sounds gooood!!