Bumps mostro core version#405
Conversation
WalkthroughThis pull request introduces several modifications across different files in the Rust project. The changes primarily involve renaming specific fields related to public keys from Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/app.rs (1)
87-88: Check for transaction consistency after trade index update.
Here, the logic updates the user’s trade index if validation succeeds. Ensure downstream code (e.g., logging or external state synchronization) is consistent after the update.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
Cargo.toml(1 hunks)src/app.rs(1 hunks)src/app/admin_take_dispute.rs(1 hunks)src/app/rate_user.rs(1 hunks)src/flow.rs(1 hunks)
🔇 Additional comments (6)
src/flow.rs (1)
87-88: Consider verifying why the trade pubkey fields are set to None.
Currently, the new code sets both order_data.buyer_trade_pubkey and order_data.seller_trade_pubkey to None when waiting for the buyer invoice. If there was previously stored data in those fields (e.g., partial trade-related information), it might be overwritten unintentionally. Confirm that clearing these fields is the intended behavior.
src/app/admin_take_dispute.rs (1)
90-95: Check the rationale for copying master pubkeys into trade pubkey fields.
The comment suggests that you're storing master pubkeys in buyer_trade_pubkey and seller_trade_pubkey. Ensure that this usage aligns with your domain logic and doesn't cause confusion elsewhere if code is expecting them to be distinct fields.
src/app/rate_user.rs (2)
97-97: Improved clarity for seller identity pubkey error.
The message is changed to "Missing seller identity pubkey," which is more descriptive. Good improvement for user understanding.
105-105: Improved clarity for buyer identity pubkey error.
Similarly, the message is changed from "Missing master buyer pubkey" to "Missing buyer identity pubkey." This more accurately reflects the nature of the missing key.
src/app.rs (1)
77-86: Explain the trade index validation logic.
When index <= user.last_trade_index, the function rejects the new trade request. This helps prevent replays or stale requests. Document or comment on why you compare the index with <= rather than <, as a strictly greater constraint might be more predictable.
Cargo.toml (1)
41-41: Verify compatibility with field renames
The version bump of mostro-core (0.6.19 -> 0.6.20) coincides with field renames in the codebase (e.g., master_buyer_pubkey -> buyer_trade_pubkey). Since this is a patch version bump, it should only contain backwards compatible changes.
Let's verify the changes in the mostro-core repository:
Consider documenting these changes in your PR description to help future maintainers understand the relationship between the version bump and the field renames.
Code refactoring and small improvements
1edade6 to
ed899a1
Compare
Code refactoring and small improvements
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores