feat(bond): Phase 3.5 payout confirmation actions on mobile by Catrya · Pull Request #603 · MostroP2P/mobile

Catrya · 2026-05-22T21:56:44Z

Add and to the Action enum
Add helper (none/pending/acknowledged/completed) with retry support
Bond payout screen: hide form on acknowledged/completed, show info + single CLOSE button
My Trades badge: PAYOUT IN PROGRESS on acknowledged; order's real status on completed
Trade Details: extend the previous non-bond message with a bond-paid line; rate hint only if is in history
: accept default to
: keep tracked order untouched on bond acks; preserve current status (don't fall to default)
Notification extractor: return null for the two new actions (no SnackBar fires)
Exhaustive switches in notification mapper/item updated as no-ops (compiler requirement; functional wiring deferred)
l10n: new keys in en/es/it/de/fr
Tests: bond payout helpers 9→17 cases; regression test for

Summary by CodeRabbit

New Features
- Added bond invoice acceptance and payout completion support with dedicated UI flows and localized messaging across five languages.
- Introduced bond payout phase tracking for improved order state management.
Bug Fixes
- Made order status field optional to handle edge case payloads.
Tests
- Added comprehensive test coverage for bond payout phase transitions and order parsing.

- Add and to the Action enum - Add helper (none/pending/acknowledged/completed) with retry support - Bond payout screen: hide form on acknowledged/completed, show info + single CLOSE button - My Trades badge: PAYOUT IN PROGRESS on acknowledged; order's real status on completed - Trade Details: extend the previous non-bond message with a bond-paid line; rate hint only if is in history - : accept default to - : keep tracked order untouched on bond acks; preserve current status (don't fall to default) - Notification extractor: return null for the two new actions (no SnackBar fires) - Exhaustive switches in notification mapper/item updated as no-ops (compiler requirement; functional wiring deferred) - l10n: new keys in en/es/it/de/fr - Tests: bond payout helpers 9→17 cases; regression test for

coderabbitai · 2026-05-22T21:56:55Z

Walkthrough

This PR implements support for two new bond-related actions—bondInvoiceAccepted and bondPayoutCompleted—to recognize and display invoice acceptance and payout completion in the anti-abuse bond flow. Changes include a new phase-state machine, order state preservation during acknowledgement, dedicated UI for completed phases, updated trade/message detail displays, and full localization.

Changes

Bond Payout Acknowledgement & Completion

Layer / File(s)	Summary
Action enum and Order model updates `lib/data/models/enums/action.dart`, `lib/data/models/order.dart`, `test/models/order_test.dart`	Action enum adds `bondInvoiceAccepted` and `bondPayoutCompleted` entries. Order.fromJson treats status as optional, defaulting to `Status.pending` when absent or null, with test coverage for null status parsing.
Bond payout phase determination `lib/shared/utils/bond_payout_helpers.dart`, `test/shared/utils/bond_payout_helpers_test.dart`	Introduces `BondPayoutPhase` enum (none/pending/acknowledged/completed) and `bondPayoutPhase(messages)` function that computes current phase from timestamped bond-related messages, with tests covering pending, acknowledged, completed, and retry scenarios.
Order state preservation for bond ack actions `lib/features/order/models/order_state.dart`	OrderState.updateWith detects bond payout ack actions and prevents order field replacement. _getStatusFromAction preserves current status for ack actions instead of deriving from payload to avoid accidental state transitions.
Bond payout invoice screen conditional rendering `lib/features/order/screens/bond_payout_invoice_screen.dart`	Screen checks computed bond phase and renders informational UI with phase-specific localized message and close button for acknowledged/completed phases; original submission form remains the fallback for pending phase.
Message detail and trade list UI updates `lib/features/trades/widgets/mostro_message_detail_widget.dart`, `lib/features/trades/widgets/trades_list_item.dart`	MostroMessageDetail derives bond phase and displays phase-specific localized messages with optional rating suffix. TradesListItem computes dynamic `bondBadgeLabel` from phase/claim state instead of boolean flag and passes it to status chip rendering.
Notification routing and message mapping `lib/features/notifications/utils/notification_data_extractor.dart`, `lib/features/notifications/utils/notification_message_mapper.dart`, `lib/features/notifications/widgets/notification_item.dart`	Routes bondInvoiceAccepted and bondPayoutCompleted through notification extraction (return null), message key mapping (stub placeholders), and tap handling (navigate to /trade_detail/{orderId}).
Multilingual support for bond payout UI `lib/l10n/intl_*.arb`	Adds five localization keys across all five languages (English, German, Spanish, French, Italian): in-progress badge, accepted/completed messages, completion-with-rating variant, and close button label.

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly Related PRs

MostroP2P/mobile#596: Adds initial bond payout claim UI and route; this PR extends it with acknowledged/completed phase rendering.
MostroP2P/mobile#116: Refactors trades list status chip rendering; this PR builds on that refactor to add bond badge label logic.
MostroP2P/mobile#552: Modifies Action enum initialization; this PR adds new enum values to the same enum.

Suggested Reviewers

AndreaDiazCorreia
BraCR10
mostronatorcoder

Poem

🐰 Two actions hop in, phase by phase,
acknowledged, completed—the bond's full race.
State preserved safe, no tumbles today,
with messages localized in every way,
the invoice accepted, the payout complete,
anti-abuse flows make the user's feat!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding mobile support for bond payout confirmation actions (Phase 3.5).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch anti-abuse-bond-phase35

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/features/notifications/utils/notification_message_mapper.dart`:
- Around line 98-100: Replace the "TODO: implement title key if needed"
placeholder returned for actions mostro.Action.bondInvoiceAccepted and
mostro.Action.bondPayoutCompleted with a real localized title lookup (e.g., use
the appropriate S.of(context).<orderUpdateTitle> or similar ARB key) inside the
notification message mapper in notification_message_mapper.dart; update the same
placeholder occurrences referenced around lines 204-206 as well, ensuring you
call the correct S.of(context).<key> accessor used elsewhere in this mapper so
no raw string falls back to the user.

In `@lib/l10n/intl_fr.arb`:
- Around line 1591-1595: The new French ARB entries (keys
bondPayoutInProgressBadge, bondInvoiceAcceptedMessage,
bondPayoutCompletedMessage, bondPayoutCompletedWithRating,
bondPayoutCloseButton) currently contain French text but should follow the repo
convention of using English placeholder text for new feature keys; update each
value to an English placeholder equivalent (e.g., "PAYMENT IN PROGRESS", "Mostro
accepted the Lightning invoice you provided to receive your share of the
anti-abuse bond. Please wait for payment to complete.", "You have received
payment of your share of the anti-abuse bond.", "You have received payment of
your share of the anti-abuse bond. You may rate your counterparty.", "CLOSE") so
translations can be added in a follow-up localization PR.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d945bb9e-5423-4a91-8842-b2bb702fd632

📥 Commits

Reviewing files that changed from the base of the PR and between 1382e71 and 75b7bba.

📒 Files selected for processing (17)

lib/data/models/enums/action.dart
lib/data/models/order.dart
lib/features/notifications/utils/notification_data_extractor.dart
lib/features/notifications/utils/notification_message_mapper.dart
lib/features/notifications/widgets/notification_item.dart
lib/features/order/models/order_state.dart
lib/features/order/screens/bond_payout_invoice_screen.dart
lib/features/trades/widgets/mostro_message_detail_widget.dart
lib/features/trades/widgets/trades_list_item.dart
lib/l10n/intl_de.arb
lib/l10n/intl_en.arb
lib/l10n/intl_es.arb
lib/l10n/intl_fr.arb
lib/l10n/intl_it.arb
lib/shared/utils/bond_payout_helpers.dart
test/models/order_test.dart
test/shared/utils/bond_payout_helpers_test.dart

ermeme

Re-reviewed the latest head. The bond payout phase handling, state preservation, UI gating, and tests all look consistent. I do not see a blocking issue on this revision.

AndreaDiazCorreia

tACK

coderabbitai Bot reviewed May 22, 2026

View reviewed changes

Comment thread lib/features/notifications/utils/notification_message_mapper.dart

Comment thread lib/l10n/intl_fr.arb

ermeme Bot approved these changes May 22, 2026

View reviewed changes

Catrya requested review from AndreaDiazCorreia and BraCR10 May 25, 2026 14:48

AndreaDiazCorreia approved these changes May 25, 2026

View reviewed changes

Catrya merged commit 6071a7f into main May 26, 2026
2 checks passed

Catrya deleted the anti-abuse-bond-phase35 branch May 26, 2026 17:59

coderabbitai Bot mentioned this pull request May 26, 2026

feat(bond): show the taker when their anti-abuse bond is slashed. Phase 4 #604

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bond): Phase 3.5 payout confirmation actions on mobile#603

feat(bond): Phase 3.5 payout confirmation actions on mobile#603
Catrya merged 1 commit into
mainfrom
anti-abuse-bond-phase35

Catrya commented May 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

ermeme Bot left a comment

Uh oh!

AndreaDiazCorreia left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Catrya commented May 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly Related PRs

Suggested Reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ermeme Bot left a comment

Choose a reason for hiding this comment

Uh oh!

AndreaDiazCorreia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Catrya commented May 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 22, 2026 •

edited

Loading