lib/features/order/notifiers/order_notifier.dart (1)

150-156: Make setFiatWasSent() idempotent to avoid redundant state emissions.

Line 154 always emits a new state even if fiatWasSent is already true. A quick guard keeps restore replays cheaper.

♻️ Proposed tweak

   void setFiatWasSent() {
-    if (mounted) {
-      state = state.copyWith(fiatWasSent: true);
-    }
+    if (!mounted || state.fiatWasSent) return;
+    state = state.copyWith(fiatWasSent: true);
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/order/notifiers/order_notifier.dart` around lines 150 - 156, The
setFiatWasSent method currently emits a new state unconditionally; change it to
be idempotent by checking the current state's fiatWasSent flag and only calling
state = state.copyWith(fiatWasSent: true) when mounted is true AND
state.fiatWasSent is false so redundant state emissions are avoided (refer to
setFiatWasSent and state.copyWith(fiatWasSent: ...)).

lib/features/notifications/utils/notification_message_mapper.dart (1)

67-73: Consider centralizing cooperative-cancel action grouping to reduce duplication.

Both getTitleKey() and getMessageKey() now repeat the same variant lists. A tiny helper keeps future additions safer.

♻️ Refactor sketch

 class NotificationMessageMapper {
+  static bool _isCooperativeCancelByYou(mostro.Action action) {
+    return action == mostro.Action.cooperativeCancelInitiatedByYou ||
+        action == mostro.Action.cooperativeCancelNoFiatByYou ||
+        action == mostro.Action.cooperativeCancelFiatSentByYou;
+  }
+
+  static bool _isCooperativeCancelByPeer(mostro.Action action) {
+    return action == mostro.Action.cooperativeCancelInitiatedByPeer ||
+        action == mostro.Action.cooperativeCancelNoFiatByPeer ||
+        action == mostro.Action.cooperativeCancelFiatSentByPeer;
+  }
+
   static String getTitleKey(mostro.Action action) {
+    if (_isCooperativeCancelByYou(action)) {
+      return 'notification_cooperative_cancel_initiated_by_you_title';
+    }
+    if (_isCooperativeCancelByPeer(action)) {
+      return 'notification_cooperative_cancel_initiated_by_peer_title';
+    }
     switch (action) {
-      case mostro.Action.cooperativeCancelInitiatedByYou:
-      case mostro.Action.cooperativeCancelNoFiatByYou:
-      case mostro.Action.cooperativeCancelFiatSentByYou:
-        return 'notification_cooperative_cancel_initiated_by_you_title';
-      case mostro.Action.cooperativeCancelInitiatedByPeer:
-      case mostro.Action.cooperativeCancelNoFiatByPeer:
-      case mostro.Action.cooperativeCancelFiatSentByPeer:
-        return 'notification_cooperative_cancel_initiated_by_peer_title';
       ...
     }
   }

   static String getMessageKey(mostro.Action action) {
+    if (_isCooperativeCancelByYou(action)) {
+      return 'notification_cooperative_cancel_initiated_by_you_message';
+    }
+    if (_isCooperativeCancelByPeer(action)) {
+      return 'notification_cooperative_cancel_initiated_by_peer_message';
+    }
     switch (action) {
-      case mostro.Action.cooperativeCancelInitiatedByYou:
-      case mostro.Action.cooperativeCancelNoFiatByYou:
-      case mostro.Action.cooperativeCancelFiatSentByYou:
-        return 'notification_cooperative_cancel_initiated_by_you_message';
-      case mostro.Action.cooperativeCancelInitiatedByPeer:
-      case mostro.Action.cooperativeCancelNoFiatByPeer:
-      case mostro.Action.cooperativeCancelFiatSentByPeer:
-        return 'notification_cooperative_cancel_initiated_by_peer_message';
       ...
     }
   }
 }

Also applies to: 169-175

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/notifications/utils/notification_message_mapper.dart` around
lines 67 - 73, Both getTitleKey() and getMessageKey() duplicate the same
cooperative-cancel action lists; extract a single helper (e.g.,
isCooperativeCancel(Action) or a constant Set<Action> cooperativeCancelActions)
that contains the variants cooperativeCancelNoFiatByYou,
cooperativeCancelFiatSentByYou, cooperativeCancelInitiatedByPeer,
cooperativeCancelNoFiatByPeer, cooperativeCancelFiatSentByPeer and use that
helper from both getTitleKey and getMessageKey to centralize the grouping and
avoid duplication.

lib/features/order/models/order_state.dart (1)

426-434: Consider removing dead code entries for generic variants in active/fiatSent matrices.

Since updateWith() now remaps cooperativeCancelInitiatedByYou/Peer to the semantic variants before getActions() is called, these entries under Status.active and Status.fiatSent will never be matched. They're harmless but could be removed for clarity.

Also applies to: 443-453, 568-576, 584-592

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/order/models/order_state.dart` around lines 426 - 434, Remove
unreachable action-list entries for Action.cooperativeCancelInitiatedByPeer and
Action.cooperativeCancelInitiatedByYou from the active/fiatSent matrices since
updateWith() now remaps those generic variants to their semantic counterparts
before getActions() runs; locate the matrices under Status.active and
Status.fiatSent in order_state.dart (also the similar blocks around the ranges
noted) and delete the lines that list
cooperativeCancelInitiatedByPeer/cooperativeCancelInitiatedByYou while leaving
the semantic variants intact so behavior is unchanged and the dead entries are
cleaned up.