fix: strip build number from desktop release version by mostronatorcoder[bot] · Pull Request #522 · MostroP2P/mobile

mostronatorcoder · 2026-03-09T19:06:11Z

Problem

The desktop workflow (desktop.yml) reads the version from pubspec.yaml including the build number (e.g. 1.2.1+936) and uses it for the release tag and asset naming. This caused:

Two separate releases — release.yml creates v1.2.1 (with APKs), then desktop.yml creates v1.2.1+936 (with desktop builds)
Inconsistent naming — Android assets are under v1.2.1, desktop assets under v1.2.1+936

Expected: one release v1.2.1 with ALL assets (APKs + desktop).

Fix

Strip the build number from the version before using it for tags and release naming:

# Before: version=1.2.1+936
# After:  version=1.2.1
version=${full_version%%+*}

This ensures desktop.yml creates/updates the release with tag v1.2.1 (matching what release.yml already created), so ncipollo/release-action with allowUpdates: true adds the desktop assets to the existing release.

Follow-up to #520

Summary by CodeRabbit

Chores
- Improved desktop build workflow to better distinguish between full version and release version information during the build process, enhancing version metadata handling and build output clarity.

Desktop workflow used full version from pubspec.yaml (e.g. 1.2.1+936) for tag and release naming, creating a separate release instead of adding assets to the existing one created by release.yml. Now strips the build number (1.2.1+936 → 1.2.1) so desktop assets get uploaded to the same release as Android APKs. Follow-up to #520

grunch · 2026-03-09T19:08:25Z

@coderabbitai review

coderabbitai · 2026-03-09T19:08:36Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-03-09T19:08:44Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8b28334a-4858-447e-8047-be2482641f4b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

The GitHub Actions workflow's version extraction step now captures the raw version in full_version, validates its non-empty state, and derives a release version by removing build metadata after a plus sign (e.g., 1.2.1+936 becomes 1.2.1). Both versions are echoed for visibility while the release version is exposed as the VERSION environment output.

Changes

Cohort / File(s)	Summary
Version Extraction Enhancement `.github/workflows/desktop.yml`	Modified version extraction to store raw version in `full_version`, validate non-empty state, and derive release version by stripping build metadata (text after `+`). Added echo statements for Full version and Release version visibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Creation of desktop application for windows and mac #340: Introduces the initial desktop workflow with version extraction logic; this PR refines that extraction to distinguish between full and release versions.

Poem

🐰 A version so clean, stripped of its clutter,
The plus sign's debris cast down to the gutter,
Now full and release dance hand in hand,
In workflows refined across the DevOps land! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: stripping build numbers from desktop release versions in the workflow file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/desktop-release-version-520

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/desktop.yml:
- Around line 116-119: The workflow currently strips build metadata into a
single VERSION variable (version=${full_version%%+*}) causing every matrix job
(Linux/macOS/Windows) to publish to the same v${{
steps.extract_version.outputs.version }} release and race via
ncipollo/release-action; fix by moving release publishing out of the matrix into
a separate non-matrix job that runs after the matrix (consume each matrix job's
upload-artifact outputs) and calls ncipollo/release-action once, or as a minimal
mitigation set replacesArtifacts: false and/or allowUpdates: false in the
release-action invocation to prevent parallel artifact replacement; update the
workflow to reference the same VERSION/GITHUB_OUTPUT produced by extract_version
but perform publishing only from the single coordinating job.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2a386c41-9219-4c5a-bd02-733ac6bc06b2

📥 Commits

Reviewing files that changed from the base of the PR and between 27f69ec and 18bab4f.

📒 Files selected for processing (1)

.github/workflows/desktop.yml

coderabbitai · 2026-03-09T19:15:41Z

+          # Strip build number for tag/release naming (1.2.1+936 → 1.2.1)
+          version=${full_version%%+*}
          echo "VERSION=$version" >> $GITHUB_ENV
          echo "version=$version" >> $GITHUB_OUTPUT


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

ncipollo/release-action Marketplace docs: what do allowUpdatesandreplacesArtifactsdo, and isreplacesArtifacts enabled by default?

💡 Result:

allowUpdates: If set, the action will update an existing release (for the tag) instead of failing/only trying to create a new one. It “defaults to false” (i.e., not enabled unless you set it). [1]

replacesArtifacts: Controls whether existing release assets (“artifacts”) are replaced when uploading artifacts to a release. [1]

Is replacesArtifacts enabled by default? Yes — its documented default is true. [1] (Also defined with default: 'true' in action.yml.) [2]

Sources: GitHub Marketplace “Create Release” (ncipollo/release-action) docs [1]; ncipollo/release-action action.yml [2].

🏁 Script executed:

cat -n .github/workflows/desktop.yml | sed -n '100,160p'

Repository: MostroP2P/mobile

Length of output: 2731

🏁 Script executed:

head -100 .github/workflows/desktop.yml | tail -60

Repository: MostroP2P/mobile

Length of output: 1966

🏁 Script executed:

head -50 .github/workflows/desktop.yml

Repository: MostroP2P/mobile

Length of output: 1594

🏁 Script executed:

tail -50 .github/workflows/desktop.yml

Repository: MostroP2P/mobile

Length of output: 2180

Publishing each matrix leg to the same tag will cause race conditions and potential asset conflicts.

Once this strips 1.2.1+936 to 1.2.1, all three platforms (Linux/macOS/Windows) target the same v${{ steps.extract_version.outputs.version }} release. The downstream ncipollo/release-action step runs once per matrix leg with allowUpdates: true and replacesArtifacts: true, meaning concurrent jobs independently update the same release. Although each platform uploads a uniquely named artifact, the uncoordinated, parallel release updates create a race condition where artifact metadata or release state could be corrupted or inconsistent. Use a separate non-matrix release job that downloads all three upload-artifact outputs and publishes once, or at minimum set replacesArtifacts: false to prevent accidental asset replacement.

Possible minimal mitigation in the downstream release step

- name: Create GitHub Release uses: ncipollo/release-action@v1 with: artifacts: "./dist/mostro-desktop-${{ steps.extract_version.outputs.version }}-${{ matrix.artifact-name }}" tag: v${{ steps.extract_version.outputs.version }} allowUpdates: true omitBodyDuringUpdate: true - replacesArtifacts: true + replacesArtifacts: false draft: false prerelease: false

A dedicated publish job that downloads all three upload-artifact outputs and calls release-action once would be safer.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In @.github/workflows/desktop.yml around lines 116 - 119, The workflow currently strips build metadata into a single VERSION variable (version=${full_version%%+*}) causing every matrix job (Linux/macOS/Windows) to publish to the same v${{ steps.extract_version.outputs.version }} release and race via ncipollo/release-action; fix by moving release publishing out of the matrix into a separate non-matrix job that runs after the matrix (consume each matrix job's upload-artifact outputs) and calls ncipollo/release-action once, or as a minimal mitigation set replacesArtifacts: false and/or allowUpdates: false in the release-action invocation to prevent parallel artifact replacement; update the workflow to reference the same VERSION/GITHUB_OUTPUT produced by extract_version but perform publishing only from the single coordinating job.

Good catch. Fixed in 3e83d12 — moved release publishing to a dedicated publish job that:

Waits for all 3 matrix builds to complete

Downloads all artifacts with actions/download-artifact

Uploads everything at once to the release

Also set replacesArtifacts: false so it won't overwrite Android assets already uploaded by release.yml.

Skipped: comment is from another GitHub bot.

Separate the release publishing from the matrix build jobs into a single 'publish' job that: 1. Waits for all 3 platform builds to complete 2. Downloads all artifacts 3. Uploads them all at once to the existing release This prevents race conditions from 3 matrix jobs concurrently updating the same release with allowUpdates+replacesArtifacts. Also set replacesArtifacts: false to avoid overwriting existing Android assets uploaded by release.yml.

grunch

LGTM

coderabbitai Bot reviewed Mar 9, 2026

View reviewed changes

grunch approved these changes Mar 9, 2026

View reviewed changes

grunch merged commit 7f75ae7 into main Mar 9, 2026
2 checks passed

grunch deleted the fix/desktop-release-version-520 branch March 9, 2026 19:27

coderabbitai Bot mentioned this pull request Mar 9, 2026

fix: release workflow — prevent double build number and fix changelog #524

Merged

coderabbitai Bot mentioned this pull request Apr 9, 2026

fix(ci): use client_payload.version in desktop workflow #559

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: strip build number from desktop release version#522

fix: strip build number from desktop release version#522
grunch merged 2 commits into
mainfrom
fix/desktop-release-version-520

mostronatorcoder Bot commented Mar 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

grunch commented Mar 9, 2026

Uh oh!

coderabbitai Bot commented Mar 9, 2026

Uh oh!

coderabbitai Bot commented Mar 9, 2026 •

edited

Loading

Review skipped

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Mar 9, 2026 •

edited

Loading

Uh oh!

mostronatorcoder Bot Mar 9, 2026

Uh oh!

coderabbitai Bot Mar 9, 2026

Uh oh!

grunch left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mostronatorcoder Bot commented Mar 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Follow-up to #520

Summary by CodeRabbit

Uh oh!

grunch commented Mar 9, 2026

Uh oh!

coderabbitai Bot commented Mar 9, 2026

Uh oh!

coderabbitai Bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mostronatorcoder Bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

grunch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mostronatorcoder Bot commented Mar 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 9, 2026 •

edited

Loading

coderabbitai Bot Mar 9, 2026 •

edited

Loading