lib/features/disputes/notifiers/dispute_chat_notifier.dart (3)

253-291: Historical messages don't pre-process encrypted media.

When loading historical messages in _loadHistoricalMessages, the _processMessageContent method is not called on unwrapped events. This means encrypted images/files won't be auto-downloaded and cached when the user opens an existing dispute chat, unlike new incoming messages in _onChatEvent.

Consider adding media processing after unwrapping historical messages for consistency:

           // Decrypt and unwrap the message
           final unwrappedEvent = await storedEvent.p2pUnwrap(session.adminSharedKey!);
+          await _processMessageContent(unwrappedEvent);
           messages.add(DisputeChatMessage(event: unwrappedEvent));

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/disputes/notifiers/dispute_chat_notifier.dart` around lines 253
- 291, The historical loader is unwrapping events but not pre-processing
encrypted media, so after reconstructing and unwrapping each storedEvent in the
loop (the variable unwrappedEvent returned by storedEvent.p2pUnwrap in the
method that loads historical messages) call the existing media processing
routine used for incoming events (invoke _processMessageContent on the
unwrappedEvent and await it if async) before creating/adding the
DisputeChatMessage; this ensures encrypted images/files are downloaded/cached
the same way as in _onChatEvent and keeps media handling consistent.

---

478-491: Service instantiation on every call.

EncryptedImageUploadService() is instantiated per image processed. If the service is stateless, consider creating it once as a field or obtaining it via a provider for consistency with the codebase's dependency injection patterns.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/disputes/notifiers/dispute_chat_notifier.dart` around lines 478
- 491, The _processEncryptedImageMessage is creating a new
EncryptedImageUploadService() for every call; instead, make
EncryptedImageUploadService a single instance (either a private final field on
the notifier class or injected via the class constructor/provider) and use that
instance inside _processEncryptedImageMessage (keep using getAdminSharedKey(),
EncryptedImageUploadResult.fromJson, downloadAndDecryptImage and
cacheDecryptedImage as before) to avoid repeated instantiation and align with DI
patterns.

---

424-448: In-memory caches grow unbounded.

The _imageCache and _fileCache maps store decrypted media indefinitely. In a long dispute conversation with many media attachments, this could lead to memory pressure. Consider adding an eviction strategy (LRU cache, max entry count, or clearing on dispose).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/disputes/notifiers/dispute_chat_notifier.dart` around lines 424
- 448, The in-memory caches _imageCache and _fileCache (and their metadata maps
_imageMetadata/_fileMetadata) grow unbounded; implement an eviction strategy by
capping entries and evicting least-recently-used items (or oldest) inside
cacheDecryptedImage and cacheDecryptedFile, or replace the plain Map with an LRU
cache implementation (or a package) and clear caches in a dispose/close method;
update getCachedImage/getCachedFile to refresh recency on access and ensure
cache size/config (max entries) is configurable.

lib/features/chat/widgets/encrypted_file_message.dart (1)

526-544: Inconsistent diacritic handling compared to EncryptedImageMessage.

This file manually replaces diacritics (lines 533-537) while encrypted_image_message.dart uses the diacritic package's removeDiacritics() function. Consider using the same approach for consistency and more comprehensive Unicode support.

♻️ Suggested refactor

+import 'package:diacritic/diacritic.dart';
 ...
   String _sanitizeFilename(String filename) {
     // 1. Get basename only (remove any directory components)
     final basename = filename.split(RegExp(r'[/\\]')).last;

-    // 2. Normalize accented characters to prevent encoding issues
-    String normalized = basename
-        .replaceAll('á', 'a').replaceAll('é', 'e').replaceAll('í', 'i')
-        .replaceAll('ó', 'o').replaceAll('ú', 'u').replaceAll('ñ', 'n')
-        .replaceAll('ü', 'u').replaceAll('Á', 'A').replaceAll('É', 'E')
-        .replaceAll('Í', 'I').replaceAll('Ó', 'O').replaceAll('Ú', 'U')
-        .replaceAll('Ñ', 'N').replaceAll('Ü', 'U');
+    // 2. Normalize using diacritic package for comprehensive Unicode support
+    String normalized = removeDiacritics(basename);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/chat/widgets/encrypted_file_message.dart` around lines 526 -
544, The _sanitizeFilename function currently does manual diacritic
replacements; replace that manual block with the diacritic package's
removeDiacritics() call for consistent and comprehensive normalization (apply
removeDiacritics to the basename before replacing spaces/unsafe chars), remove
the chain of replaceAll(...) for accented chars, add the diacritic import
(import 'package:diacritic/diacritic.dart';) and ensure the package is in
pubspec.yaml if not already; keep the remaining steps (basename extraction,
whitespace->underscore, dangerous-char regex, '..' replacement) unchanged.

lib/features/disputes/notifiers/dispute_chat_notifier.dart (1)

425-431: Unbounded in-memory caches may cause memory pressure in long sessions.

The four cache maps (_imageCache, _imageMetadata, _fileCache, _fileMetadata) grow without bound as media messages are processed, and dispose() does not clear them. For disputes with many media messages or long-running sessions, this could lead to significant memory consumption.

Consider clearing the caches in dispose():

♻️ Proposed fix to clear caches on dispose

 `@override`
 void dispose() {
   _subscription?.cancel();
   _sessionListener?.close();
+  _imageCache.clear();
+  _imageMetadata.clear();
+  _fileCache.clear();
+  _fileMetadata.clear();
   super.dispose();
 }

Also applies to: 551-556

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/disputes/notifiers/dispute_chat_notifier.dart` around lines 425
- 431, The maps _imageCache, _imageMetadata, _fileCache, and _fileMetadata are
unbounded and not cleared, causing memory pressure; update the
DisputeChatNotifier.dispose() method to clear (call .clear() on) each of those
maps (and any other similar caches around lines referenced like the other cache
pair at 551-556) to free memory on teardown, and optionally replace or wrap
these maps with a bounded/LRU cache implementation if long-lived sessions need
retention rather than full clear.

lib/features/disputes/notifiers/dispute_chat_notifier.dart (1)

10-10: Avoid decoding the same payload twice.

_processMessageContent already has jsonContent, but the helpers in lib/features/chat/utils/message_type_helpers.dart:6-30 decode message.content again. Switching on the parsed type here removes the extra decode on every media message/history replay and lets this notifier drop the helper import.

♻️ Example simplification

-import 'package:mostro_mobile/features/chat/utils/message_type_helpers.dart';
...
-      if (jsonContent != null) {
-        if (MessageTypeUtils.isEncryptedImageMessage(message)) {
-          await _processEncryptedImageMessage(message, jsonContent);
-        } else if (MessageTypeUtils.isEncryptedFileMessage(message)) {
-          await _processEncryptedFileMessage(message, jsonContent);
-        }
-      }
+      switch (jsonContent?['type']) {
+        case 'image_encrypted':
+          await _processEncryptedImageMessage(message, jsonContent!);
+          break;
+        case 'file_encrypted':
+          await _processEncryptedFileMessage(message, jsonContent!);
+          break;
+      }

Also applies to: 458-473

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/features/disputes/notifiers/dispute_chat_notifier.dart` at line 10, The
notifier decodes message.content twice: _processMessageContent already parses
jsonContent but code and the helpers in message_type_helpers.dart re-decode
message.content; update the logic inside _processMessageContent (and the similar
block at the other occurrence) to switch on the already-parsed
jsonContent['type'] (or its parsed enum) and call the appropriate handling
directly instead of calling the helpers that re-decode message.content, then
remove the now-unused import of
package:mostro_mobile/features/chat/utils/message_type_helpers.dart; ensure you
update both the main occurrence and the other block referenced (lines ~458-473)
to avoid duplicate decoding.