fix: Prevent combining fixed price with range orders in order creation#439
Merged
Conversation
Contributor
WalkthroughAdds range-order mode propagation and UI/validation to prevent selecting Fixed Price when a max amount is present. The parent screen tracks Changes
Sequence DiagramsequenceDiagram
actor User
participant AmountSection as AmountSection
participant AddOrderScreen as AddOrderScreen
participant PriceTypeSection as PriceTypeSection
User->>AmountSection: Focus max amount (first time)
AmountSection->>AddOrderScreen: onRangeModeChanged(true)
AddOrderScreen->>AddOrderScreen: set _isRangeMode = true
AddOrderScreen->>PriceTypeSection: pass updated props (errorMessage / disabled state)
User->>PriceTypeSection: Attempt toggle to Fixed
PriceTypeSection->>AddOrderScreen: onToggle(request Fixed)
AddOrderScreen->>AddOrderScreen: _showFixedPriceRangeError()
AddOrderScreen->>PriceTypeSection: update errorMessage
PriceTypeSection->>User: display fixedPriceDisabledForRange message
User->>AmountSection: Clear max amount
AmountSection->>AddOrderScreen: onRangeModeChanged(false)
AddOrderScreen->>PriceTypeSection: clear errorMessage / allow Fixed
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@lib/features/order/screens/add_order_screen.dart`:
- Around line 103-114: The _showFixedPriceRangeError function can start
overlapping timers that clear a newer message early; add a Timer field (e.g.,
_fixedPriceRangeErrorTimer) to the widget, cancel it if non-null and active at
the start of _showFixedPriceRangeError, then create a new
Timer(Duration(seconds:5)) that clears _fixedPriceRangeError inside the mounted
check and assigns null to the timer when it fires; ensure you import dart:async
and cancel the timer in dispose() as well.
In `@lib/l10n/intl_en.arb`:
- Around line 1366-1367: Remove the non-placeholder metadata entry named
"@_comment_range_fixed_price" and leave only the plain localization key
"fixedPriceDisabledForRange" (do not add any `@-prefixed` metadata for it),
ensuring ARB metadata blocks are present only for keys with placeholders; locate
and delete the "@_comment_range_fixed_price" entry near the
"fixedPriceDisabledForRange" key.
In `@lib/l10n/intl_es.arb`:
- Around line 1342-1343: Remove the stray ARB metadata entry named
"@_comment_range_fixed_price" and keep only the actual message key
"fixedPriceDisabledForRange"; locate the pair ("@_comment_range_fixed_price" and
"fixedPriceDisabledForRange") and delete the metadata line so that only the
translation string remains, and ensure any remaining `@-prefixed` metadata is used
only for keys that have placeholders.
In `@lib/l10n/intl_it.arb`:
- Around line 1397-1399: Remove the metadata-only entry
`@_comment_range_fixed_price` from the ARB file because metadata (`@-prefixed`)
should only accompany parameterized keys; keep the user-facing key
fixedPriceDisabledForRange (and its value) intact and delete the separate
"@_comment_range_fixed_price" line so only parameterized strings retain metadata
blocks.
Member
|
@Catrya please fix conflicts |
# Conflicts: # lib/l10n/intl_en.arb # lib/l10n/intl_es.arb # lib/l10n/intl_it.arb
AndreaDiazCorreia
left a comment
Member
There was a problem hiding this comment.
No esta duplicando la evaluacion de _isRangeMode? veo que en add_order_screen tiene su boolean y que tambien esta en AmountSection, no estaria redundando ahi? de resto lo probe y anda bien, la pregunta es solo curiosidad
Member
Author
No es redundancia, rastrean cosas distintas: en AmountSection el _isRangeMode indica si el usuario interactuó con el campo max (estado de UI), mientras que en AddOrderScreen refleja si la orden es de rango (_isRangeMode && hasMax), que es lo que llega por el callback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #434
Now, if someone tries to create a range order at a fixed price, it will not be allowed, and a message will appear for 5 seconds explaining why it remains at market price.
Summary by CodeRabbit
New Features
Localization