lib/shared/widgets/notification_listener_widget.dart (3)

9-9: Prevent instantiation of static-only mapper.

Make the class non-instantiable.

-class CantDoNotificationMapper {
+class CantDoNotificationMapper {
+  CantDoNotificationMapper._();

---

11-27: Nit: avoid the null-bang on S.of(context) if not needed.

If the generated l10n API returns non-null, drop ! to satisfy lints. Apply across entries.

-    'pending_order_exists': (context) => S.of(context)!.pendingOrderExists,
+    'pending_order_exists': (context) => S.of(context).pendingOrderExists,

---

29-36: Log unknown cant-do reasons for observability.

Keep user-facing fallback, but log the unhandled reason to catch gaps.

-    // Fallback to generic cant-do message
-    return NotificationMessageMapper.getLocalizedTitle(context, mostro.Action.cantDo);
+    // Fallback to generic cant-do message
+    assert(() {
+      // Helps surface missing mappings in debug builds.
+      // ignore: avoid_print
+      print('[CantDoNotificationMapper] Unhandled cant-do reason: $cantDoReason');
+      return true;
+    }());
+    return NotificationMessageMapper.getLocalizedTitle(context, mostro.Action.cantDo);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-28T20:32:34.625Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: chebizarro
PR: MostroP2P/mobile#127
File: lib/data/models/cant_do.dart:10-27
Timestamp: 2025-07-08T05:40:47.527Z
Learning: In the CantDo model parsing in lib/data/models/cant_do.dart, the inconsistent key naming between 'cant_do' (top-level) and 'cant-do' (nested) is required by the protocol specification and should not be changed as it would break message parsing compatibility.

Learnt from: Catrya
PR: MostroP2P/mobile#215
File: lib/features/order/notfiers/order_notifier.dart:0-0
Timestamp: 2025-07-20T23:33:17.689Z
Learning: In AbstractMostroNotifier, the handleEvent method is synchronous and returns void, not Future<void>. Do not suggest adding await to super.handleEvent() calls as this would cause compilation errors.

Learnt from: chebizarro
PR: MostroP2P/mobile#127
File: lib/features/order/notfiers/abstract_mostro_notifier.dart:45-54
Timestamp: 2025-06-26T15:03:23.529Z
Learning: In AbstractMostroNotifier, state updates occur for all messages regardless of timestamp to hydrate the OrderNotifier from MostroStorage during sync, while handleEvent is only called for recent messages (within 60 seconds) to prevent re-triggering side effects like notifications and navigation for previously handled messages. This design prevents displaying stale notifications when the app is reopened or brought to the foreground.

lib/l10n/intl_es.arb (1)

136-136: Brand capitalization fixed — looks good.

“Mostro” is correctly capitalized now and the phrasing reads naturally.

lib/shared/widgets/notification_listener_widget.dart (1)

74-81: Guard next.values to avoid runtime exceptions on malformed payloads.

If values is null or not a Map, current code will throw. Safely check before indexing.

-          if (next.action == mostro.Action.cantDo) {
-            final reason = next.values['action'];
+          if (next.action == mostro.Action.cantDo) {
+            final rawValues = next.values;
+            final reason = rawValues is Map ? rawValues['action'] : null;
             if (reason is String && reason.isNotEmpty) {
               message = CantDoNotificationMapper.getMessage(context, reason);
             } else {
               // Fallback if the payload is malformed or type changes
               message = NotificationMessageMapper.getLocalizedTitle(context, mostro.Action.cantDo);
             }
           } else {

lib/shared/widgets/notification_listener_widget.dart (2)

10-30: Good centralization; add remaining cant-do mappings for full coverage.

You already cover most reasons; include the rest so we don’t fall back to generic when we have specific strings.

   static final _messageMap = <String, String Function(BuildContext)>{
@@
     'invalid_order_status': (context) => S.of(context)!.invalidOrderStatus,
+    'invalid_payment_request': (context) => S.of(context)!.invalidPaymentRequest,
+    'invalid_text_message': (context) => S.of(context)!.invalidTextMessage,
+    'invalid_parameters': (context) => S.of(context)!.invalidParameters,
+    'is_not_your_dispute': (context) => S.of(context)!.isNotYourDispute,
+    'dispute_creation_error': (context) => S.of(context)!.disputeCreationError,
+    'not_found': (context) => S.of(context)!.notFound,
+    'invalid_dispute_status': (context) => S.of(context)!.invalidDisputeStatus,
+    'invalid_action': (context) => S.of(context)!.invalidAction,
   };

---

32-42: Fallback is correct; consider a tiny unit test.

Add a test asserting a known reason returns the specific message and an unknown reason hits the generic fallback.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-28T20:32:34.625Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: chebizarro
PR: MostroP2P/mobile#127
File: lib/data/models/cant_do.dart:10-27
Timestamp: 2025-07-08T05:40:47.527Z
Learning: In the CantDo model parsing in lib/data/models/cant_do.dart, the inconsistent key naming between 'cant_do' (top-level) and 'cant-do' (nested) is required by the protocol specification and should not be changed as it would break message parsing compatibility.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-28T20:32:34.625Z
Learning: Use Riverpod for state management with Notifiers encapsulating business logic; access data only through repositories