feat: improve maker UX when order is taken by counterpart by Catrya · Pull Request #251 · MostroP2P/mobile

Catrya · 2025-08-01T23:53:18Z

Prevent auto-navigation and show waiting message for makers when their orders are taken, while preserving original behavior for takers.
Add personalized message for makers waiting for counterpart response

Summary by CodeRabbit

New Features
- Displayed customized messages based on whether the user is the order creator or taker during specific order states.
- Improved navigation behavior to only redirect users to trade details when relevant to their role and order type.
Localization
- Added new localized messages for English, Spanish, and Italian to inform users when their order is taken and awaiting a counterpart’s action.

Prevent auto-navigation and show waiting message for makers when their orders are taken, while preserving original behavior for takers.

coderabbitai · 2025-08-01T23:53:24Z

Walkthrough

This update introduces user role-aware logic for both navigation and displayed messages in order-related flows. Conditional checks now determine navigation and message content based on whether the user is the creator (maker) or taker of an order, with corresponding updates to localization files to support new user-facing messages in English, Spanish, and Italian.

Changes

Cohort / File(s)	Change Summary
Order Notifier Logic Update `lib/features/order/notfiers/abstract_mostro_notifier.dart`	Added conditional navigation in `handleEvent` for certain actions, using a new private `_isUserCreator()` method to determine if the current user is the maker of the order and adjusting navigation accordingly.
Role-based Message Display `lib/features/trades/widgets/mostro_message_detail_widget.dart`	Introduced logic to display different messages based on whether the user is the order creator or taker, with a new `_isUserCreator` helper method.
Localization: English `lib/l10n/intl_en.arb`	Added a new key and message for "orderTakenWaitingCounterpart" with placeholder for expiration time, including metadata.
Localization: Spanish `lib/l10n/intl_es.arb`	Added Spanish translation for "orderTakenWaitingCounterpart" with placeholder and metadata.
Localization: Italian `lib/l10n/intl_it.arb`	Added Italian translation for "orderTakenWaitingCounterpart" with placeholder and metadata.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant Notifier
    participant Session

    User->>UI: Triggers order-related action
    UI->>Notifier: handleEvent(action, order)
    Notifier->>Session: Get user session and role
    Notifier->>Notifier: _isUserCreator(session, order)
    alt User is creator and action matches
        Notifier-->>UI: Skip navigation
    else User is not creator or action does not match
        Notifier-->>UI: Navigate to trade detail
    end

sequenceDiagram
    participant User
    participant UI
    participant MessageWidget
    participant Session

    User->>UI: Views order message
    UI->>MessageWidget: buildMessage(tradeState)
    MessageWidget->>Session: Get user session and role
    MessageWidget->>MessageWidget: _isUserCreator(session, tradeState)
    alt User is creator and action matches
        MessageWidget-->>UI: Show "orderTakenWaitingCounterpart" message
    else
        MessageWidget-->>UI: Show default waiting message
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

feat: implement timeout detection and reversal system for orders in waiting-payment and waiting-buyer-invoice #243: Modifies AbstractMostroNotifier.handleEvent to add a new timeoutReversal action, similar in scope as it also extends event handling logic in the same class.

Suggested reviewers

chebizarro
grunch

Poem

In the warren of code, a bunny did find
Roles and messages, carefully aligned.
Makers and takers, now see what’s true—
The screen shows a message just for you!
With hops and with checks, translations anew,
This rabbit says: “Great job, team—thank you!” 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch orderTakenWaitingCounterpart

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

lib/l10n/intl_en.arb (1)

78-86: Keep locale files in sync and fix seconds/minutes wording

Good addition, but please:

Confirm orderTakenWaitingCounterpart is also present in intl_it.arb.

Decide whether expiration_seconds should be expressed in seconds or minutes to avoid user-visible confusion.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6b682e and 3b26939.

📒 Files selected for processing (5)

lib/features/order/notfiers/abstract_mostro_notifier.dart (3 hunks)
lib/features/trades/widgets/mostro_message_detail_widget.dart (3 hunks)
lib/l10n/intl_en.arb (1 hunks)
lib/l10n/intl_es.arb (1 hunks)
lib/l10n/intl_it.arb (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

lib/**/*.dart