Fixes: Add confirmation message before starting cooperative cancellation by chebizarro · Pull Request #128 · MostroP2P/mobile

chebizarro · 2025-07-02T20:07:01Z

Now shows a confirmation dialog before cancelling the order for Issue #72

Summary by CodeRabbit

Improvements
- Countdown timer and creation timestamp formatting were updated for improved accuracy.
- Cancel action now prompts a confirmation dialog with context-sensitive messaging before proceeding.
- Added a contact button for direct messaging within the action buttons.
- Close button now navigates directly to the order book screen for a smoother experience.
- Expanded availability of direct messaging in various trade states for enhanced communication.

…ion #72

coderabbitai · 2025-07-02T20:07:07Z

Walkthrough

The trade detail screen was updated to ensure timestamps are handled in milliseconds and to improve the cancel action by adding a confirmation dialog with context-sensitive messaging. The send direct message action was repositioned among user-facing buttons, and the close button now navigates to the order book screen instead of simply popping the route. The order state model was extended to allow the sendDm action in additional trade statuses and roles.

Changes

File	Change Summary
lib/features/trades/screens/trade_detail_screen.dart	Adjusted timestamp handling to use milliseconds, added confirmation dialog for cancel, reorganized action buttons, updated close button navigation.
lib/features/order/models/order_state.dart	Added `sendDm` action to allowed next actions for multiple statuses and roles in the `actions` map.

Suggested reviewers

Catrya

Poem

In the world of trades, a hop and a leap,
Timers now tick in milliseconds deep.
Cancel with care—confirm before you go,
And messages to friends are easier to show.
With every tweak, the order book’s in sight,
Rabbits code onward, through day and night! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36bfa73 and 1e82193.

📒 Files selected for processing (1)

lib/features/trades/screens/trade_detail_screen.dart (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

lib/features/trades/screens/trade_detail_screen.dart

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Catrya

Hi @chebizarro , it works fine when the user is going to initiate a cooperative cancellation, but when the counterparty receives the message that the other has initiated a cancellation, the cancel button does not appear (issue #126 ) so I can not test if tapping Cancel button in that case only sends Mostro the Cancel action to accept the cancellation, or if the client shows the message If you confirm, you will start a cooperative cancellation with your counterparty. That message should only be displayed when opening the cancellation, not when accepting it.

…l button UI (fixes Show Cancel and Dispute buttons when counterparty opens a cooperative cancellation #126)

…ancellation

Catrya

tACK
good job @chebizarro

grunch

utACK

Fixes: Add confirmation message before starting cooperative cancellat…

e8e4f27

…ion #72

chebizarro requested a review from Catrya July 2, 2025 20:07

Catrya reviewed Jul 3, 2025

View reviewed changes

chebizarro added 2 commits July 2, 2025 21:08

feat: add sendDm action to order state transitions and simplify cance…

36bfa73

…l button UI (fixes Show Cancel and Dispute buttons when counterparty opens a cooperative cancellation #126)

feat: add conditional cancel message for peer-initiated cooperative c…

1e82193

…ancellation

Catrya approved these changes Jul 3, 2025

View reviewed changes

grunch approved these changes Jul 3, 2025

View reviewed changes

grunch merged commit 1f0fcf0 into main Jul 3, 2025
1 check passed

grunch deleted the chebizarro/issue72 branch July 3, 2025 15:46

Catrya mentioned this pull request Jul 3, 2025

Show Cancel and Dispute buttons when counterparty opens a cooperative cancellation #126

Closed

coderabbitai Bot mentioned this pull request Apr 15, 2026

fix: context-aware buttons during cooperative cancellation #576

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes: Add confirmation message before starting cooperative cancellation#128

Fixes: Add confirmation message before starting cooperative cancellation#128
grunch merged 3 commits into
mainfrom
chebizarro/issue72

chebizarro commented Jul 2, 2025 •

edited by grunch

Loading

Uh oh!

coderabbitai Bot commented Jul 2, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Catrya left a comment

Uh oh!

Catrya left a comment

Uh oh!

grunch left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chebizarro commented Jul 2, 2025 • edited by grunch Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Catrya left a comment

Choose a reason for hiding this comment

Uh oh!

Catrya left a comment

Choose a reason for hiding this comment

Uh oh!

grunch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chebizarro commented Jul 2, 2025 •

edited by grunch

Loading

coderabbitai Bot commented Jul 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)