fix: Eliminate background flash on InstalledAppInfo → patch flow transition

MarcaDian · MarcaDian · commit b246a4bf0322 · 2026-05-01T09:42:36.000+03:00
diff --git a/app/src/main/java/app/morphe/manager/ui/screen/home/HomeDialogs.kt b/app/src/main/java/app/morphe/manager/ui/screen/home/HomeDialogs.kt
@@ -316,7 +316,6 @@ fun HomeDialogs(
                 packageName = packageName,
                 onDismiss = homeViewModel::dismissInstalledAppInfo,
                 onTriggerPatchFlow = { originalPackageName ->
-                    homeViewModel.dismissInstalledAppInfo()
                     homeViewModel.showPatchDialog(originalPackageName)
                 },
                 homeViewModel = homeViewModel,
diff --git a/app/src/main/java/app/morphe/manager/ui/screen/home/InstalledAppInfoDialog.kt b/app/src/main/java/app/morphe/manager/ui/screen/home/InstalledAppInfoDialog.kt
@@ -254,11 +254,13 @@ fun InstalledAppInfoDialog(
         }
     )
 
-    // Expert Mode Repatch Dialog is rendered by HomeDialogs via homeViewModel.showExpertModeDialog.
     // Patch flow always starts with onTriggerPatchFlow → showPatchDialog → ApkAvailabilityDialog,
     // where the user picks the APK source. Expert mode dialog opens after APK selection.
+    // We do NOT call onDismiss() here. InstalledAppInfoDialog stays open (hidden behind
+    // ApkAvailabilityDialog) and is dismissed in HomeViewModel.proceedWithPatching() right
+    // before navigating to PatcherScreen. This eliminates the flash of background that would
+    // appear between closing this dialog and opening the next one
     fun handlePatchClick() {
-        onDismiss()
         onTriggerPatchFlow(viewModel.installedApp?.originalPackageName ?: return)
     }
 
@@ -338,7 +340,6 @@ fun InstalledAppInfoDialog(
                                     buttonText = stringResource(R.string.patch),
                                     buttonIcon = Icons.Outlined.AutoFixHigh,
                                     onClick = {
-                                        onDismiss()
                                         onTriggerPatchFlow(installedApp.originalPackageName)
                                     },
                                     isError = true
@@ -358,7 +359,6 @@ fun InstalledAppInfoDialog(
                                     buttonText = stringResource(R.string.patch),
                                     buttonIcon = Icons.Outlined.AutoFixHigh,
                                     onClick = {
-                                        onDismiss()
                                         onTriggerPatchFlow(installedApp.originalPackageName)
                                     },
                                     isError = false
@@ -440,7 +440,6 @@ fun InstalledAppInfoDialog(
                                             buttonText = stringResource(R.string.patch),
                                             buttonIcon = Icons.Outlined.AutoFixHigh,
                                             onClick = {
-                                                onDismiss()
                                                 onTriggerPatchFlow(installedApp.originalPackageName)
                                             },
                                             isError = true,
@@ -464,7 +463,6 @@ fun InstalledAppInfoDialog(
                                             buttonText = stringResource(R.string.patch),
                                             buttonIcon = Icons.Outlined.AutoFixHigh,
                                             onClick = {
-                                                onDismiss()
                                                 onTriggerPatchFlow(installedApp.originalPackageName)
                                             },
                                             isError = false,
diff --git a/app/src/main/java/app/morphe/manager/ui/viewmodel/HomeViewModel.kt b/app/src/main/java/app/morphe/manager/ui/viewmodel/HomeViewModel.kt
@@ -122,7 +122,7 @@ data class SavedApkInfo(
 )
 
 /**
- * Combined home screen app state — emitted atomically so visible and hidden lists
+ * Combined home screen app state - emitted atomically so visible and hidden lists
  * are always in sync and never cause a transient empty-state flash.
  */
 data class HomeAppState(
@@ -1859,6 +1859,10 @@ class HomeViewModel(
         patches: PatchSelection,
         options: Options
     ) {
+        // Dismiss InstalledAppInfoDialog here, right before navigating to PatcherScreen.
+        // This ensures there is never a gap between the info dialog closing and the next screen appearing
+        dismissInstalledAppInfo()
+
         onStartQuickPatch?.invoke(
             QuickPatchParams(
                 selectedApp = selectedApp,
