Skip to content

bug: --verify-with-sdk argh does not work correctly on Windows #137

@cyberboh

Description

@cyberboh

Bug description

I am paching YouTube with --verify-with-sdk but it throws error (see log below). Actually dexdump.exe already inside the folder.
Tested CLI 1.8.0-dev.9, Azul JDK 21, Windows 10 IoT LTSC 64-bit.

Error logs

java.lang.IllegalArgumentException: dexdump not found or not executable: C:\build-tools\36.0.0\dexdump
        at app.morphe.patcher.dex.SdkDexVerifier.<init>(DexVerifier.kt:94)
        at app.morphe.patcher.dex.SdkDexVerifier.<init>(DexVerifier.kt:70)
        at app.morphe.cli.command.PatchCommand.call(PatchCommand.kt:457)
        at app.morphe.cli.command.PatchCommand.call(PatchCommand.kt:51)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2031)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2469)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2423)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2425)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.morphe.MorpheLauncherKt.main(MorpheLauncher.kt:23)

Solution

Seems SdkDexVerifier can not verify dexdump.exe because on the error log written only dexdump which is type file for UNIX system like linux or mac.
Maybe add simple OS detection can fix it, like If OS=Windows_NT search file dexdump.exe. This is just noob solution, maybe you guys have beter solution.

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions