fix(#357): comp-time Win. ext. for run handler#358
Conversation
MordechaiHadad
left a comment
There was a problem hiding this comment.
Could you change this to a simple let bin_path = if cfg! clause instead of like this, the current approach is good but i prefer it to be concise.
|
@MordechaiHadad - Yeah, happy to update this to use a conditional macro. Wrote it this way as conditional macros ( |
This addresses issue MordechaiHadad#357 by adding comp-time handling for Windows systems. Previously the `run_handler` fn was not not correctly appending the `.exe` extension to the Neovim binary path, this hot-fix addresses this. Closes MordechaiHadad#357
PR Review comment requested to use
`let bin_path = if cfg!(...) {...}` over platform annotations/decos
for binary path. This update addresses that.
670a5eb to
edcd230
Compare
|
This has been updated to match |
Fair I don't care that much for having those compiled its very small imo to early optimize them. |
This addresses issue #357 by adding comp-time handling for Windows systems.
Previously the
run_handlerfn was not not correctly appending the.exeextension to the Neovim binary path, this hot-fix addresses this.Closes #357