@MrDwarf7 I did not notice your PR. I also did a fix but simply switches an if statment: parse the commit first then the version. #353

This was my initial call too.

I figured to check other sections of the CodeBase as I've been working with it on and off for awhile now & figured I'd triple check the actual RegEx that we're compiling. I would say it's a bug as we're not (originally) enforcing the existence of the full stop during parsing.

Rust aims to move as much of its validation logic, or really any logic that it can, to compile time, over procedural validations and relying on ordering of checks. Procedural validations can be dangerous in that they allow for invalid states to exist (often way too far into the program lifespan).

Rust has ample tools to enforce this via enums & matches-even things like the Ord trait are available if so desired.
I tend to favour the 'write your program in such a way that "invalid states are unpresentable"' approach as you get a logically congruent program that tends to be fairly easy to follow too.

Relying on match check ordering without a way to enforce it at compile time is bugs waiting to happen for sure.

Just so im up to date with the approach used to fix the issue, to clarify the issue, the thing that failed identifying the hash was because the previous regex pattern didn't enforce dots?

Correct, I've tested this locally with all commands that make use of the call.

@MordechaiHadad - The unit value ( I presume you're referring to 450-451 in use_handler.rs?) Was a clippy lint, most of these I just went through an applied them after a brief surrounding code review to make sure surrounding code wouldn't require refactoring for it. You can see it in the commit 6dd1b75.

The if let Some(i) = selection in rollback_handler.rs was also a clippy lint, I tend to prefer single instance fall-through's as they require less cognitive overhead (imo). I found this a bit of an odd one too. If you want I can add a #[clippy(allow(...))] to it and simply use a fall-through; it is after all, the last component to that function call.

@MordechaiHadad - The unit value ( I presume you're referring to 450-451 in use_handler.rs?) Was a clippy lint, most of these I just went through an applied them after a brief surrounding code review to make sure surrounding code wouldn't require refactoring for it. You can see it in the commit 6dd1b75.

The if let Some(i) = selection in rollback_handler.rs was also a clippy lint, I tend to prefer single instance fall-through's as they require less cognitive overhead (imo). I found this a bit of an odd one too. If you want I can add a #[clippy(allow(...))] to it and simply use a fall-through; it is after all, the last component to that function call.

Oh damn you already changed lmao, I was okay with these changes which is why i approved just wanted to make sure before merging. If clippy says we follow clippy.