fix(#339): resolve symlinks#343
Merged
Merged
Conversation
Contributor
Author
|
@MordechaiHadad - Ready for review 👍 |
Added a sh/bash script that helps test the proxy binary. Fairly configurable and has documentation/output where useful
Closes: MordechaiHadad#339 Addresses issue where executable name resolution fails when symlinked wtih a name that is not `nvim`. With this change a link from `$HOME/.local/share/bob/nvim-bin/nvim` to any name will still resolve as intended. When the executable was run via a symlink, the previous method of extracting would only look at the output side of the symlink, leading to incorrect behavior.
56f9b47 to
26a1847
Compare
Owner
|
Great solution, apologies for not merging this sooner I got caught up with life responsibilities.
btw is this a yugioh reference? if so nice. |
Contributor
Author
|
@MordechaiHadad - Yeah it's a reference, because who doesn't like a bit of humor in their test suite tooling? |
MordechaiHadad
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #339
Addresses issue where executable name resolution fails when symlinked wtih a name that is not
nvim.With this change a link from
$HOME/.local/share/bob/nvim-bin/nvimto any name will still resolve as intended.When the executable was run via a symlink, the previous method of extracting would only look at the output side of the symlink, leading to incorrect behavior.
Note:
Have yet to run it in a WSL environment (given the issue), and don't have a way to test MacOS and how it handles symlinks (apparently they can be a bit weird sometimes from my learning).