hotfix/perf(#331): removes padding on list-remote output#333
Merged
MordechaiHadad merged 2 commits intoOct 13, 2025
Conversation
Removal of padding variable and associated usage in list-remote command output formatting. This also moves the syscall for requesting the stdout lock to be as late as possible in the current stack frame, to minimize overhead.
Contributor
Author
|
Closes the associated issue (#331). |
MordechaiHadad
approved these changes
Oct 13, 2025
1c4e033 to
cf86210
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removal of padding when calling
bob list-remoteThe padding variable and associated usage in the
list_remote_handler.rsfile have been removed.Performance change
There's no need to request an
io::stdoutlock any early than the moment we require output.To achieve this I've used a
Vec::with_capacity(1024)via a buffer (basically a char buffer).Outputting to this via
writeln!(...)and only calling theio::stdout().lock()after theif-elsechain.I've also implemented explicit error output handling for
io::ErrorKind::BrokenPipeand added proper flushing for the stdout lock.